You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/27 19:10:46 UTC
[GitHub] [netbeans] jlahoda opened a new pull request #2497: Avoid registering the LSP client's hyperlink provider unless the given file is handled by the LSP client.
jlahoda opened a new pull request #2497:
URL: https://github.com/apache/netbeans/pull/2497
This is a tweak to:
https://github.com/apache/netbeans/pull/2483
The LSP client's hyperlink provider should ignore files that are not handled by the LSP client (for performance reasons, at least), this patch moves the flag at a more correct place. Sorry I didn't have time to look at 2483, and for trouble with this bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #2497: Avoid registering the LSP client's hyperlink provider unless the given file is handled by the LSP client.
Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #2497:
URL: https://github.com/apache/netbeans/pull/2497#issuecomment-717774443
Not sure what exactly is the connection either - the thrown exception probably cancelled the action handling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2497: Avoid registering the LSP client's hyperlink provider unless the given file is handled by the LSP client.
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2497:
URL: https://github.com/apache/netbeans/pull/2497
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #2497: Avoid registering the LSP client's hyperlink provider unless the given file is handled by the LSP client.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #2497:
URL: https://github.com/apache/netbeans/pull/2497#issuecomment-717862112
@jlahoda is this also the reason URL's in Java source (in Javadoc) are no longer working in 12.2-beta2? I noticed this while working on something yesterday - stack trace has LSP code in it.
```
java.lang.Exception
[catch] at org.netbeans.lib.lexer.TokenHierarchyOperation.ensureReadLocked(TokenHierarchyOperation.java:387)
at org.netbeans.lib.lexer.TokenHierarchyOperation.tokenSequence(TokenHierarchyOperation.java:411)
at org.netbeans.lib.lexer.TokenHierarchyOperation.tokenSequence(TokenHierarchyOperation.java:407)
at org.netbeans.api.lexer.TokenHierarchy.tokenSequence(TokenHierarchy.java:161)
at org.netbeans.modules.lsp.client.bindings.HyperlinkProviderImpl.getHyperlinkSpan(HyperlinkProviderImpl.java:75)
at org.netbeans.modules.lsp.client.bindings.HyperlinkProviderImpl.isHyperlinkPoint(HyperlinkProviderImpl.java:62)
at org.netbeans.lib.editor.hyperlink.HyperlinkOperation.findProvider(HyperlinkOperation.java:266)
at org.netbeans.lib.editor.hyperlink.HyperlinkOperation.performAction(HyperlinkOperation.java:240)
at org.netbeans.lib.editor.hyperlink.HyperlinkOperation.mouseClicked(HyperlinkOperation.java:422)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #2497: Avoid registering the LSP client's hyperlink provider unless the given file is handled by the LSP client.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #2497:
URL: https://github.com/apache/netbeans/pull/2497#issuecomment-717862112
@jlahoda is this also the reason URL's in Java source (in Javadoc) are no longer working in 12.2-beta2? I noticed this working yesterday - stack trace has LSP code in it.
```
java.lang.Exception
[catch] at org.netbeans.lib.lexer.TokenHierarchyOperation.ensureReadLocked(TokenHierarchyOperation.java:387)
at org.netbeans.lib.lexer.TokenHierarchyOperation.tokenSequence(TokenHierarchyOperation.java:411)
at org.netbeans.lib.lexer.TokenHierarchyOperation.tokenSequence(TokenHierarchyOperation.java:407)
at org.netbeans.api.lexer.TokenHierarchy.tokenSequence(TokenHierarchy.java:161)
at org.netbeans.modules.lsp.client.bindings.HyperlinkProviderImpl.getHyperlinkSpan(HyperlinkProviderImpl.java:75)
at org.netbeans.modules.lsp.client.bindings.HyperlinkProviderImpl.isHyperlinkPoint(HyperlinkProviderImpl.java:62)
at org.netbeans.lib.editor.hyperlink.HyperlinkOperation.findProvider(HyperlinkOperation.java:266)
at org.netbeans.lib.editor.hyperlink.HyperlinkOperation.performAction(HyperlinkOperation.java:240)
at org.netbeans.lib.editor.hyperlink.HyperlinkOperation.mouseClicked(HyperlinkOperation.java:422)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2497: Avoid registering the LSP client's hyperlink provider unless the given file is handled by the LSP client.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2497:
URL: https://github.com/apache/netbeans/pull/2497#issuecomment-717862112
@jlahoda is this also the reason URL's in Java source (in Javadoc) are no longer working in 12.2-beta2? I noticed this working yesterday - stack trace has LSP code in it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists