You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/04/18 03:24:03 UTC

[GitHub] [arrow] mapleFU commented on pull request #34002: GH-34001: [C++] Add more rvalue overload for Status::operator&

mapleFU commented on PR #34002:
URL: https://github.com/apache/arrow/pull/34002#issuecomment-1512380209

   @PragmaTwice It's `value_or` like code here: https://github.com/llvm-mirror/libcxx/blob/master/include/optional#L132-L133 ? And you use explicit ctor using `(const Status&)` and `Status&&` to represent universal reference? I think both your change and https://github.com/apache/arrow/pull/34002#discussion_r1099944171 is ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org