You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Michael Dick (JIRA)" <ji...@apache.org> on 2010/12/13 23:30:00 UTC

[jira] Created: (OPENJPA-1906) Issue info / warning message when connection retain mode is always

Issue info / warning message when connection retain mode is always
------------------------------------------------------------------

                 Key: OPENJPA-1906
                 URL: https://issues.apache.org/jira/browse/OPENJPA-1906
             Project: OpenJPA
          Issue Type: Bug
          Components: logging
    Affects Versions: 2.2.0
            Reporter: Michael Dick
            Assignee: Michael Dick
            Priority: Minor
             Fix For: 2.2.0


Many users see better performance when setting openjpa.ConnectionRetainMode to always. But they might not be aware of the consequences - the EntityManager must be closed in order to release the connection. 

In the case of application managed entity managers, the application should always close the EntityManager when it's done. But since this may or may not be obvious, it's a good idea to log an info message. 

In the case where the application cannot directly close the EntityManager (e.g. a Container Managed EntityManager), we should log a warning to let users know that each EntityManager may hold on to a connection for a long time. 

Unfortunately we can only detect whether the EMF is container managed, not the EM - but some warning is better than none. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OPENJPA-1906) Issue info / warning message when connection retain mode is always

Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dick closed OPENJPA-1906.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.0

> Issue info / warning message when connection retain mode is always
> ------------------------------------------------------------------
>
>                 Key: OPENJPA-1906
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1906
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: logging
>    Affects Versions: 2.2.0
>            Reporter: Michael Dick
>            Assignee: Michael Dick
>            Priority: Minor
>             Fix For: 2.1.0, 2.2.0
>
>
> Many users see better performance when setting openjpa.ConnectionRetainMode to always. But they might not be aware of the consequences - the EntityManager must be closed in order to release the connection. 
> In the case of application managed entity managers, the application should always close the EntityManager when it's done. But since this may or may not be obvious, it's a good idea to log an info message. 
> In the case where the application cannot directly close the EntityManager (e.g. a Container Managed EntityManager), we should log a warning to let users know that each EntityManager may hold on to a connection for a long time. 
> Unfortunately we can only detect whether the EMF is container managed, not the EM - but some warning is better than none. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-1906) Issue info / warning message when connection retain mode is always

Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971724#action_12971724 ] 

Michael Dick commented on OPENJPA-1906:
---------------------------------------

The change has been committed to trunk under revision 1045397. My typo in the commit message prevents it from linking here. 

> Issue info / warning message when connection retain mode is always
> ------------------------------------------------------------------
>
>                 Key: OPENJPA-1906
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1906
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: logging
>    Affects Versions: 2.2.0
>            Reporter: Michael Dick
>            Assignee: Michael Dick
>            Priority: Minor
>             Fix For: 2.2.0
>
>
> Many users see better performance when setting openjpa.ConnectionRetainMode to always. But they might not be aware of the consequences - the EntityManager must be closed in order to release the connection. 
> In the case of application managed entity managers, the application should always close the EntityManager when it's done. But since this may or may not be obvious, it's a good idea to log an info message. 
> In the case where the application cannot directly close the EntityManager (e.g. a Container Managed EntityManager), we should log a warning to let users know that each EntityManager may hold on to a connection for a long time. 
> Unfortunately we can only detect whether the EMF is container managed, not the EM - but some warning is better than none. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.