You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bahir.apache.org by ckadner <gi...@git.apache.org> on 2016/07/22 06:55:32 UTC

[GitHub] bahir pull request #11: [BAHIR-35] add Python sources to binary jar for use ...

GitHub user ckadner opened a pull request:

    https://github.com/apache/bahir/pull/11

    [BAHIR-35] add Python sources to binary jar for use with `spark-submit --packages \u2026`

    [BAHIR-35: Include Python code in the binary jars for use with "--packages ..."](https://issues.apache.org/jira/browse/BAHIR-35)
    
    **Change:**
    
    Adding `${basedir}/python/**/*.py` files as `<resources>` in the build section of `pom.xml`:
    ```xml
    ...
      <build>
        <resources>
          <resource>
            <directory>${basedir}/python</directory>
            <includes>
              <include>**/*.py</include>
            </includes>
          </resource>
        </resources>
        ...
    ```
    Currently only the **MQTT** Streaming connector is affected by this change.
    
    **Test:**
    
    After PR #10 is merged, run the following commands:
    
    ```console
    mvn clean install
    
    rm -rf ~/.ivy2/cache/org.apache.bahir/
    
    mosquitto -p 1883
    
    bin/run-example \
        org.apache.spark.examples.streaming.mqtt.MQTTPublisher tcp://localhost:1883 foo
    
    ${SPARK_HOME}/bin/spark-submit \
        --packages org.apache.bahir:spark-streaming-mqtt_2.11:2.0.0-SNAPSHOT \
        streaming-mqtt/examples/src/main/python/streaming/mqtt_wordcount.py \
        tcp://localhost:1883 foo
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ckadner/bahir BAHIR-35_include_Python_sources_in_binary_build

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bahir/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11
    
----
commit 4c41f20b46cf782d64b1e5b45ec910806e67c71d
Author: Christian Kadner <ck...@us.ibm.com>
Date:   2016-07-22T06:43:49Z

    [BAHIR-35] add Python sources to binary build for use with `spark-submit --packages ...`

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bahir pull request #11: [BAHIR-35] add Python sources to binary jar for use ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/bahir/pull/11


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bahir issue #11: [BAHIR-35] add Python sources to binary jar for use with `s...

Posted by deroneriksson <gi...@git.apache.org>.
Github user deroneriksson commented on the issue:

    https://github.com/apache/bahir/pull/11
  
    LGTM @ckadner 
    
    Building spark-streaming-mqtt with current master results in no *.py files in the artifact. After this PR, building spark-streaming-mqtt results in artifact with *.py files at root level of the artifact (__init__.py, dstream.py, and mqtt.py).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bahir issue #11: [BAHIR-35] add Python sources to binary jar for use with `s...

Posted by ckadner <gi...@git.apache.org>.
Github user ckadner commented on the issue:

    https://github.com/apache/bahir/pull/11
  
    @deroneriksson - **Thank you** for your review!
    
    @lresende - Do you have any comments or suggestions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---