You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/04/14 09:46:43 UTC

[GitHub] [camel-quarkus] ppalaga opened a new pull request #2474: Revisit the documentation #2136 #2470 #2374

ppalaga opened a new pull request #2474:
URL: https://github.com/apache/camel-quarkus/pull/2474


   Fix #2136 
   Fix #2470 
   Fix #2374
   
   Please follow the instructions in `docs/README.adoc` to get an HTML preview


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #2474: Revisit the documentation #2136 #2470 #2374

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #2474:
URL: https://github.com/apache/camel-quarkus/pull/2474#discussion_r613110003



##########
File path: docs/modules/ROOT/pages/user-guide/first-steps.adoc
##########
@@ -101,6 +115,11 @@ The application has three compile dependencies:
 
 They are managed within the `camel-quarkus-bom` that is imported in `<dependencyManagement>`.
 
+[INFO]
+====
+More about xref:user-guide/dependency-management.adoc[BoMs].

Review comment:
       Is the mixed case `BoMs` intended?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2474: Revisit the documentation #2136 #2470 #2374

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2474:
URL: https://github.com/apache/camel-quarkus/pull/2474#discussion_r613145687



##########
File path: docs/modules/ROOT/pages/user-guide/first-steps.adoc
##########
@@ -101,6 +115,11 @@ The application has three compile dependencies:
 
 They are managed within the `camel-quarkus-bom` that is imported in `<dependencyManagement>`.
 
+[INFO]
+====
+More about xref:user-guide/dependency-management.adoc[BoMs].

Review comment:
       Yes, but I do not mind switching to BOM, if you like.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #2474: Revisit the documentation #2136 #2470 #2374

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2474:
URL: https://github.com/apache/camel-quarkus/pull/2474#issuecomment-819446545


   3b5c643 : `s/BoM/BOM/`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #2474: Revisit the documentation #2136 #2470 #2374

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #2474:
URL: https://github.com/apache/camel-quarkus/pull/2474#discussion_r613151270



##########
File path: docs/modules/ROOT/pages/user-guide/first-steps.adoc
##########
@@ -101,6 +115,11 @@ The application has three compile dependencies:
 
 They are managed within the `camel-quarkus-bom` that is imported in `<dependencyManagement>`.
 
+[INFO]
+====
+More about xref:user-guide/dependency-management.adoc[BoMs].

Review comment:
       I'll leave it for you to decide. It's an acronym, so BOM is more correct. If you don't want to waste time tweaking it, then it's no big deal. PR looks good otherwise :+1: 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga merged pull request #2474: Revisit the documentation #2136 #2470 #2374

Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2474:
URL: https://github.com/apache/camel-quarkus/pull/2474


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org