[GitHub] [arrow] lidavidm commented on a change in pull request #10738: ARROW-13219: [C++][GLib] Demote/deprecate CompareOptions

[GitBox <gi...@apache.org>]

lidavidm commented on a change in pull request #10738:
URL: https://github.com/apache/arrow/pull/10738#discussion_r671764971



##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -218,11 +218,9 @@ enum CompareOperator : int8_t {
   LESS_EQUAL,
 };
 
-class ARROW_EXPORT CompareOptions : public FunctionOptions {

Review comment:
       On second thought, deprecating the enum would make some of the tests/benchmarks below annoying to write and it would be a tedious refactor. So let's not do that here - since this is about GLib - once this removes the GLib dependency we can go in and fully clean up CompareOptions.

##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -218,11 +218,9 @@ enum CompareOperator : int8_t {
   LESS_EQUAL,
 };
 
-class ARROW_EXPORT CompareOptions : public FunctionOptions {

Review comment:
       Perhaps we should deprecate the struct and CompareOperator enum as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org