Re: [PR] [parquet-thrift] move on from java 8 [parquet-java]

["dossett (via GitHub)" <gi...@apache.org>]

dossett commented on code in PR #3378:
URL: https://github.com/apache/parquet-java/pull/3378#discussion_r2759576384


##########
parquet-thrift/src/main/java/org/apache/parquet/thrift/struct/ThriftType.java:
##########
@@ -502,12 +502,7 @@ public EnumType(@JsonProperty("values") List<EnumValue> values) {
     }
 
     public Iterable<EnumValue> getValues() {
-      return new Iterable<EnumValue>() {
-        @Override
-        public Iterator<EnumValue> iterator() {
-          return values.iterator();
-        }
-      };
+      return List.copyOf(values);

Review Comment:
   Update this to just `return values::iterator` since that's in keeping with the spirit of the PR (java modernization). Other changes could be discussed separately.  Thanks @Fokko 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org