Re: flex-asjs git commit: I’m not sure if cljs compiler will rename these. To be on the safe side…

[Piotr Zarzycki <pi...@gmail.com>]

Harbs,

What do you think to rename "eventObject" to "event" and before switch
create new variable ?

var eventObject:Object = event["event_"]; - Later use it in the switch.

Just changes for readability.

Thanks, Piotr

2017-07-20 9:35 GMT+02:00 <ha...@apache.org>:

> Repository: flex-asjs
> Updated Branches:
>   refs/heads/browser-event c14db8d7c -> 6d4b664a3
>
>
> I’m not sure if cljs compiler will rename these. To be on the safe side…
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/6d4b664a
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/6d4b664a
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/6d4b664a
>
> Branch: refs/heads/browser-event
> Commit: 6d4b664a3a936f2559b2b73275ca1d6b8443d159
> Parents: c14db8d
> Author: Harbs <ha...@in-tools.com>
> Authored: Thu Jul 20 10:35:01 2017 +0300
> Committer: Harbs <ha...@in-tools.com>
> Committed: Thu Jul 20 10:35:01 2017 +0300
>
> ----------------------------------------------------------------------
>  .../Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> 6d4b664a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/
> HTMLElementWrapper.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as
> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> core/HTMLElementWrapper.as
> index 8bd93b9..0324700 100644
> --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> core/HTMLElementWrapper.as
> +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> core/HTMLElementWrapper.as
> @@ -68,7 +68,7 @@ package org.apache.flex.core
>                 static public function fireListenerOverride(listener:Object,
> eventObject:goog.events.BrowserEvent):Boolean
>                 {
>              var e:IBrowserEvent;
> -            switch(eventObject["event_"].constructor.name)
> +            switch(eventObject["event_"]["constructor"]["name"])
>              {
>                  case "KeyboardEvent":
>                      e = KeyboardEventConverter.
> convert(eventObject["event_"]);
>
>