You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Gary Gregory <ga...@gmail.com> on 2017/05/10 00:10:11 UTC
Move TrustSelfSignedStrategy and TrustAllStrategy from HttpClient 5
to HttpCore 5
Hi All,
I would like to move TrustSelfSignedStrategy and TrustAllStrategy from
HttpClient 5 to HttpCore 5.
The reason is that the SslContextBuilder is in HttpCore and that is the
most public place TrustStrategy implementations are used (in my use cases
at least.)
Furthermore, when I want to use TrustSelfSignedStrategy and
TrustAllStrategy I have to drag in HttpClient when that is in fact the only
two classes I need.
Thoughts?
Gary
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Move TrustSelfSignedStrategy and TrustAllStrategy from HttpClient
5 to HttpCore 5
Posted by sebb <se...@gmail.com>.
On 10 May 2017 at 17:34, Gary Gregory <ga...@gmail.com> wrote:
> On Wed, May 10, 2017 at 12:49 AM, Oleg Kalnichevski <ol...@apache.org>
> wrote:
>
>> On Tue, 2017-05-09 at 17:10 -0700, Gary Gregory wrote:
>> > Hi All,
>> >
>> > I would like to move TrustSelfSignedStrategy and TrustAllStrategy
>> > from
>> > HttpClient 5 to HttpCore 5.
>> >
>> > The reason is that the SslContextBuilder is in HttpCore and that is
>> > the
>> > most public place TrustStrategy implementations are used (in my use
>> > cases
>> > at least.)
>> >
>> > Furthermore, when I want to use TrustSelfSignedStrategy and
>> > TrustAllStrategy I have to drag in HttpClient when that is in fact
>> > the only
>> > two classes I need.
>> >
>> > Thoughts?
>> >
>> > Gary
>>
>> Why? Those are one line implementations. Under normal circumstances
>> people should not even be using those classes.
+1
>>
>
> Testing is a 'normal circumstance' for me and customers and using a self
> signed certificate makes testing possible on any server anywhere.
>
> These classes should not be used _in production_ for certain. But even
> them, some customers can play fast and loose on their private networks to
> get things off the ground.
>
> So in my mind, all of this makes for normal circumstances.
I disagree.
> Gary
>
>
>> Oleg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>> For additional commands, e-mail: dev-help@hc.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: Move TrustSelfSignedStrategy and TrustAllStrategy from HttpClient
5 to HttpCore 5
Posted by Gary Gregory <ga...@gmail.com>.
On Wed, May 10, 2017 at 12:49 AM, Oleg Kalnichevski <ol...@apache.org>
wrote:
> On Tue, 2017-05-09 at 17:10 -0700, Gary Gregory wrote:
> > Hi All,
> >
> > I would like to move TrustSelfSignedStrategy and TrustAllStrategy
> > from
> > HttpClient 5 to HttpCore 5.
> >
> > The reason is that the SslContextBuilder is in HttpCore and that is
> > the
> > most public place TrustStrategy implementations are used (in my use
> > cases
> > at least.)
> >
> > Furthermore, when I want to use TrustSelfSignedStrategy and
> > TrustAllStrategy I have to drag in HttpClient when that is in fact
> > the only
> > two classes I need.
> >
> > Thoughts?
> >
> > Gary
>
> Why? Those are one line implementations. Under normal circumstances
> people should not even be using those classes.
>
Testing is a 'normal circumstance' for me and customers and using a self
signed certificate makes testing possible on any server anywhere.
These classes should not be used _in production_ for certain. But even
them, some customers can play fast and loose on their private networks to
get things off the ground.
So in my mind, all of this makes for normal circumstances.
Gary
> Oleg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Move TrustSelfSignedStrategy and TrustAllStrategy from
HttpClient 5 to HttpCore 5
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Tue, 2017-05-09 at 17:10 -0700, Gary Gregory wrote:
> Hi All,
>
> I would like to move TrustSelfSignedStrategy and TrustAllStrategy
> from
> HttpClient 5 to HttpCore 5.
>
> The reason is that the SslContextBuilder is in HttpCore and that is
> the
> most public place TrustStrategy implementations are used (in my use
> cases
> at least.)
>
> Furthermore, when I want to use TrustSelfSignedStrategy and
> TrustAllStrategy I have to drag in HttpClient when that is in fact
> the only
> two classes I need.
>
> Thoughts?
>
> Gary
Why? Those are one line implementations. Under normal circumstances
people should not even be using those classes.
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org