[jira] [Commented] (PHOENIX-6063) Remove bugus jline and sqlline dependency from phoenix-core

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172344#comment-17172344 ] 

Hadoop QA commented on PHOENIX-6063:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/13009176/PHOENIX-6063.4.x.v1.patch
  against 4.x branch at commit ffeddf55328ac69dac6ee565abec34e1f7002d13.
  ATTACHMENT ID: 13009176

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 0 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PointInTimeQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinGlobalIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertSelectIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.GroupByIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForNonTxGlobalIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IntArithmeticIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.RowValueConstructorOffsetIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4088//testReport/
Code Coverage results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4088//artifact/phoenix-core/target/site/jacoco/index.html
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4088//console

This message is automatically generated.

> Remove bugus jline and sqlline dependency from phoenix-core
> -----------------------------------------------------------
>
>                 Key: PHOENIX-6063
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6063
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 4.16.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>         Attachments: PHOENIX-6063.4.x.v1.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> On the 4.x branch, sqlline and jline are specified as phoenix-core dependencies.
> These only appear in two spurious imports in the code.
> Move the sqlline dependency to phoenix-client, which traditionally has it included.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)