You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/20 09:18:32 UTC
[GitHub] [pulsar] shibd opened a new pull request, #15235: Revert "Fix: LockManagerTest.updateValue is flaky (#13911)"
shibd opened a new pull request, #15235:
URL: https://github.com/apache/pulsar/pull/15235
### Motivation
https://github.com/apache/pulsar/issues/15091
The essential reason for https://github.com/apache/pulsar/pull/13911 is that two threads execute the refresh method concurrently. In PR https://github.com/apache/pulsar/pull/13911 change, it doesn't completely solve the problem, just avoid concurrent access by threads.
In #14283, The problem was radically resolved by changing below.
```
objCache.asMap().computeIfPresent(path, (oldKey, oldValue) -> readValueFromStore(path));
```
So, revert this commit.
### Modifications
- Revert "Fix: LockManagerTest.updateValue is flaky (#13911)"
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #15235: Revert "Fix: LockManagerTest.updateValue is flaky (#13911)"
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #15235:
URL: https://github.com/apache/pulsar/pull/15235#issuecomment-1104627253
> @shibd So we need another solution for the flaky test? this PR just revert the previous solution?
No need, Because #14283 also solved these flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao merged pull request #15235: Revert "Fix: LockManagerTest.updateValue is flaky (#13911)"
Posted by GitBox <gi...@apache.org>.
mattisonchao merged PR #15235:
URL: https://github.com/apache/pulsar/pull/15235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #15235: Revert "Fix: LockManagerTest.updateValue is flaky (#13911)"
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #15235:
URL: https://github.com/apache/pulsar/pull/15235#issuecomment-1104598777
@shibd So we need another solution for the flaky test? this PR just revert the previous solution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org