You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2013/07/30 22:24:16 UTC
Review Request 13079: Modify Messenger credit distribution algorithm to
support credit rebalancing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13079/
-----------------------------------------------------------
Review request for qpid and Rafael Schloming.
Bugs: proton-200
https://issues.apache.org/jira/browse/proton-200
Repository: qpid
Description
-------
This patch improves the existing credit allocation scheme used by messenger.
Currently passes the new python tests for proton-c, still need to fix the tests for the other test targets.
Diffs
-----
/proton/trunk/proton-c/bindings/python/proton.py 1508023
/proton/trunk/proton-c/include/proton/messenger.h 1508023
/proton/trunk/proton-c/src/messenger/messenger.c 1508023
/proton/trunk/tests/python/proton_tests/messenger.py 1508023
Diff: https://reviews.apache.org/r/13079/diff/
Testing
-------
New unit tests added. Additional work necessary to get the java/jni tests to pass, which I will do before checking in the patch.
Thanks,
Kenneth Giusti
Re: Review Request 13079: Modify Messenger credit distribution algorithm to
support credit rebalancing
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13079/
-----------------------------------------------------------
(Updated Sept. 6, 2013, 3:39 p.m.)
Review request for qpid and Rafael Schloming.
Changes
-------
Have new tests skip the Java Messenger for now, as that impl is TBD.
Note you'll have to apply patches from PROTON-401 and PROTON-375 in order for this feature to work.
Bugs: proton-200
https://issues.apache.org/jira/browse/proton-200
Repository: qpid
Description
-------
This patch improves the existing credit allocation scheme used by messenger.
Currently passes the new python tests for proton-c, still need to fix the tests for the other test targets.
Diffs (updated)
-----
/proton/trunk/proton-c/bindings/python/proton.py 1520574
/proton/trunk/proton-c/include/proton/messenger.h 1520574
/proton/trunk/proton-c/src/messenger/messenger.c 1520574
/proton/trunk/proton-c/src/util.h 1520574
/proton/trunk/tests/python/proton_tests/messenger.py 1520574
Diff: https://reviews.apache.org/r/13079/diff/
Testing
-------
New unit tests added. Additional work necessary to get the java/jni tests to pass, which I will do before checking in the patch.
Thanks,
Kenneth Giusti
Re: Review Request 13079: Modify Messenger credit distribution algorithm to
support credit rebalancing
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13079/
-----------------------------------------------------------
(Updated Aug. 20, 2013, 5:36 p.m.)
Review request for qpid and Rafael Schloming.
Changes
-------
Final update.
This patch requires the fixes from PROTON-401 and PROTON-375 be applied first.
Bugs: proton-200
https://issues.apache.org/jira/browse/proton-200
Repository: qpid
Description
-------
This patch improves the existing credit allocation scheme used by messenger.
Currently passes the new python tests for proton-c, still need to fix the tests for the other test targets.
Diffs (updated)
-----
/proton/trunk/proton-c/bindings/python/proton.py 1515860
/proton/trunk/proton-c/include/proton/messenger.h 1515860
/proton/trunk/proton-c/src/messenger/messenger.c 1515860
/proton/trunk/proton-c/src/util.h 1515860
/proton/trunk/tests/python/proton_tests/messenger.py 1515860
Diff: https://reviews.apache.org/r/13079/diff/
Testing
-------
New unit tests added. Additional work necessary to get the java/jni tests to pass, which I will do before checking in the patch.
Thanks,
Kenneth Giusti
Re: Review Request 13079: Modify Messenger credit distribution algorithm to
support credit rebalancing
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13079/#review24279
-----------------------------------------------------------
/proton/trunk/proton-c/src/messenger/messenger.c
<https://reviews.apache.org/r/13079/#comment48114>
This seems incorrect: should the new value of N override the last value, or increase the last value by N?
- Kenneth Giusti
On July 30, 2013, 8:24 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13079/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 8:24 p.m.)
>
>
> Review request for qpid and Rafael Schloming.
>
>
> Bugs: proton-200
> https://issues.apache.org/jira/browse/proton-200
>
>
> Repository: qpid
>
>
> Description
> -------
>
> This patch improves the existing credit allocation scheme used by messenger.
>
> Currently passes the new python tests for proton-c, still need to fix the tests for the other test targets.
>
>
> Diffs
> -----
>
> /proton/trunk/proton-c/bindings/python/proton.py 1508023
> /proton/trunk/proton-c/include/proton/messenger.h 1508023
> /proton/trunk/proton-c/src/messenger/messenger.c 1508023
> /proton/trunk/tests/python/proton_tests/messenger.py 1508023
>
> Diff: https://reviews.apache.org/r/13079/diff/
>
>
> Testing
> -------
>
> New unit tests added. Additional work necessary to get the java/jni tests to pass, which I will do before checking in the patch.
>
>
> Thanks,
>
> Kenneth Giusti
>
>