[GitHub] [fineract] adamsaghy commented on a diff in pull request #2928: FINERACT-1855-Arrears-aging-job-as-business-step

["adamsaghy (via GitHub)" <gi...@apache.org>]

adamsaghy commented on code in PR #2928:
URL: https://github.com/apache/fineract/pull/2928#discussion_r1086794905


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/jobs/updateloanarrearsageing/UpdateLoanArrearsAgeingTasklet.java:
##########
@@ -84,18 +98,25 @@ public RepeatStatus execute(StepContribution contribution, ChunkContext chunkCon
         }
 
         log.debug("{}: Records affected by updateLoanArrearsAgeingDetails: {}", ThreadLocalContextUtil.getTenant().getName(), result);
-        return RepeatStatus.FINISHED;
     }
 
-    private List<String> updateLoanArrearsAgeingDetailsWithOriginalSchedule() {
+    private List<String> updateLoanArrearsAgeingDetailsWithOriginalSchedule(String loanIdsForUpdate) {

Review Comment:
   Please use Long (loanId is usually Long). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org