You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/07/30 12:06:24 UTC

[GitHub] [commons-vfs] PeterAlfredLee opened a new pull request #108: Add proxy config for some Http/Https test

PeterAlfredLee opened a new pull request #108:
URL: https://github.com/apache/commons-vfs/pull/108


   Some tests are failing because of the absence of the Http/Https proxy configure.
   This is a fix for them.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-vfs] garydgregory commented on pull request #108: Add proxy config for some Http/Https test

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #108:
URL: https://github.com/apache/commons-vfs/pull/108#issuecomment-667671508


   @PeterAlfredLee 
   Yes, please refactor the duplicate code, I think we can merge this in after.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-vfs] PeterAlfredLee commented on pull request #108: Add proxy config for some Http/Https test

Posted by GitBox <gi...@apache.org>.
PeterAlfredLee commented on pull request #108:
URL: https://github.com/apache/commons-vfs/pull/108#issuecomment-667760160


   Hi, @garydgregory @ecki 
   
   I agree with you two about the duplicate code. But it seems the `setProxyHost` and `setProxyPort` in `HttpFileSystemConfigBuilder`, `Http4FileSystemConfigBuilder` and `Http5FileSystemConfigBuilder` are not inherited from their common father class or any other interface class. In other words, they implemented the `setProxyHost` and `setProxyPort` separately but only share the same method name.
   
   This make it a bit difficult for me to extract the duplicate code, I can only think of the reflect way to do this([here](https://github.com/PeterAlfredLee/commons-vfs/commit/36e1275c348cc995e55ab48f95e09bfc8bcb6e66)). Do you think this is a good idea? Or you have some better ideas?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-vfs] garydgregory commented on pull request #108: Add proxy config for some Http/Https test

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #108:
URL: https://github.com/apache/commons-vfs/pull/108#issuecomment-667790864


   Ah, I see. It's too bad about the shared names outside of an interface or a hierarchy. Reflection is a no-go IMO. I'll review again tomorrow as I think the PR should be OK.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-vfs] PeterAlfredLee commented on pull request #108: Add proxy config for some Http/Https test

Posted by GitBox <gi...@apache.org>.
PeterAlfredLee commented on pull request #108:
URL: https://github.com/apache/commons-vfs/pull/108#issuecomment-667451631


   Hi @garydgregory 
   This is a PR for those machines behind a proxy - some tests are failing because of the lack of the proxy configure for these tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-vfs] garydgregory commented on pull request #108: Add proxy config for some Http/Https test

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #108:
URL: https://github.com/apache/commons-vfs/pull/108#issuecomment-666667825


   Hi @PeterAlfredLee 
   
   What does this fix? The Java 8 & 11 builds are green on Travis: https://travis-ci.org/github/apache/commons-vfs/builds/713326898
   
   Java 14 and 15 are failing due to WebDav and JackRabbit 1.x but that is not what you fixing here.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-vfs] garydgregory merged pull request #108: Add proxy config for some Http/Https test

Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #108:
URL: https://github.com/apache/commons-vfs/pull/108


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-vfs] ecki commented on pull request #108: Add proxy config for some Http/Https test

Posted by GitBox <gi...@apache.org>.
ecki commented on pull request #108:
URL: https://github.com/apache/commons-vfs/pull/108#issuecomment-667453615


   I think the change is fine, imwould maybe centralize the config helper function, but there is quite a bit of redundancy in the http providers,anyways
   
   Alternative fix would be to stark a mock test server locally.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org