[jira] [Commented] (S2GRAPH-220) Filter clause is not working on AnnoyModelFetcher

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/S2GRAPH-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512211#comment-16512211 ] 

ASF GitHub Bot commented on S2GRAPH-220:
----------------------------------------

GitHub user SteamShon opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/171

    [S2GRAPH-220]: Filter clause is not working on AnnoyModelFetcher

    - Extract Where and EdgeTransformer to TraversalHelper.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-220

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/171.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #171
    
----
commit 3355701f00b34d5e1609e8424d09b50e8211e87a
Author: DO YUNG YOON <st...@...>
Date:   2018-06-14T09:14:22Z

    Extract Where and EdgeTransformer to TraversalHelper.

----


> Filter clause is not working on AnnoyModelFetcher
> -------------------------------------------------
>
>                 Key: S2GRAPH-220
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-220
>             Project: S2Graph
>          Issue Type: Bug
>          Components: s2core, s2graphql
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>            Priority: Minor
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Below query should filter all edges that have property 'score' smaller than 0.1 but current implementation return edges with larger score property value than 0.1.
> {noformat}
> {
>   s2graph {
>     user(id: 0) {
>       friends(limit: 10, filter: "score < 0.1") {
>         user {
>           id
>         }
>       }
>     }
>   }
> }
> {noformat}
> After a look through the current master, I found out Where parser and EdgeTransformer are processed on AsynchbaseEdgeFetcher and RocksEdgeFetcher by calling StorageIO.toEdges method, but this is missing on AnnoyModelFetcher.
> I suggest to extract `Where` and `EdgeTransformer` from StorageIO.toEdges to helper so other Fetcher implementation can easily use this helper to apply them correctly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)