You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/11 15:29:26 UTC
[GitHub] [camel-website] avgupt opened a new pull request #194: Mobile Menu
Enhancement
avgupt opened a new pull request #194: Mobile Menu Enhancement
URL: https://github.com/apache/camel-website/pull/194
Fixes: https://issues.apache.org/jira/browse/CAMEL-14695?filter=12348381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #194: Mobile Menu
Enhancement
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #194: Mobile Menu Enhancement
URL: https://github.com/apache/camel-website/pull/194#issuecomment-597781519
> @zregvart this looks super clean :).
> But if we can include the search box now and like @psingh587 did in her PR #192 if now applied it will be a great achievement as per mobile screen navbar standard.
> what do you guys have to say @zregvart , @oscerd and @psingh587
> If this PR #194 gets merged.Then the work on PR #192 can be smoothly done and the main objective of PR #191 will be achieved. :)
I agree with @CSElonewolf here. I think there's a lot more scope to this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #194: Mobile Menu
Enhancement
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #194: Mobile Menu Enhancement
URL: https://github.com/apache/camel-website/pull/194#issuecomment-597775222
@zregvart this looks super clean :).
But if we can include the search box now and like @psingh587 did in her PR #192 if now applied it will be a great achievement as per mobile screen navbar standard.
what do you guys have to say @zregvart , @oscerd and @psingh587
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf edited a comment on issue #194: Mobile
Menu Enhancement
Posted by GitBox <gi...@apache.org>.
CSElonewolf edited a comment on issue #194: Mobile Menu Enhancement
URL: https://github.com/apache/camel-website/pull/194#issuecomment-597775222
@zregvart this looks super clean :).
But if we can include the search box now and like @psingh587 did in her PR #192 if now applied it will be a great achievement as per mobile screen navbar standard.
what do you guys have to say @zregvart , @oscerd and @psingh587
If this PR #194 gets merged.Then the work on PR #192 can be smoothly done and the main objective of PR #191 will be achieved. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #194: Mobile Menu
Enhancement
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #194: Mobile Menu Enhancement
URL: https://github.com/apache/camel-website/pull/194#issuecomment-597782866
Well @psingh587 I am working on it let's see what happens.Hopefully some awesome happens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf edited a comment on issue #194: Mobile
Menu Enhancement
Posted by GitBox <gi...@apache.org>.
CSElonewolf edited a comment on issue #194: Mobile Menu Enhancement
URL: https://github.com/apache/camel-website/pull/194#issuecomment-597775222
@zregvart this looks super clean :).
But if we can include the search box now and like @psingh587 did in her PR #192 if now applied it will be a great achievement as per mobile screen navbar standard.
what do you guys have to say @zregvart , @oscerd and @psingh587
If this PR #194 gets merged.Then the work on PR #192 can be smoothly done and the main objective of PR #191 will be achieved. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart merged pull request #194: Mobile Menu
Enhancement
Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #194: Mobile Menu Enhancement
URL: https://github.com/apache/camel-website/pull/194
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf edited a comment on issue #194: Mobile
Menu Enhancement
Posted by GitBox <gi...@apache.org>.
CSElonewolf edited a comment on issue #194: Mobile Menu Enhancement
URL: https://github.com/apache/camel-website/pull/194#issuecomment-597793420
> Okay so looks like we can merge this and then proceed as suggested in [#194 (comment)](https://github.com/apache/camel-website/pull/194#issuecomment-597775222). Thank you all!
@zregvart Yeah.Visit PR #191 and check the changes made.
<img width="242" alt="yyyy" src="https://user-images.githubusercontent.com/51082429/76450318-923e9880-63f3-11ea-8572-c7bbdb637538.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #194: Mobile Menu
Enhancement
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #194: Mobile Menu Enhancement
URL: https://github.com/apache/camel-website/pull/194#issuecomment-597791664
Okay so looks like we can merge this and then proceed as suggested in https://github.com/apache/camel-website/pull/194#issuecomment-597775222. Thank you all!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] avgupt commented on issue #194: Mobile Menu
Enhancement
Posted by GitBox <gi...@apache.org>.
avgupt commented on issue #194: Mobile Menu Enhancement
URL: https://github.com/apache/camel-website/pull/194#issuecomment-597701981
@zregvart Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #194: Mobile Menu
Enhancement
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #194: Mobile Menu Enhancement
URL: https://github.com/apache/camel-website/pull/194#issuecomment-597768268
Preview is [here](https://builds.apache.org/job/Camel.website/job/PR-194/Preview/index.html).
Here is how it looks on width of 360:
@psingh587 and @CSElonewolf what do you think of this, is it compatible with the approach you're taking? Can we go ahead with this and with your changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #194: Mobile Menu
Enhancement
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #194: Mobile Menu Enhancement
URL: https://github.com/apache/camel-website/pull/194#issuecomment-597793420
> Okay so looks like we can merge this and then proceed as suggested in [#194 (comment)](https://github.com/apache/camel-website/pull/194#issuecomment-597775222). Thank you all!
Yeah.Visit PR #191 and check the changes made.
<img width="242" alt="yyyy" src="https://user-images.githubusercontent.com/51082429/76450318-923e9880-63f3-11ea-8572-c7bbdb637538.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 edited a comment on issue #194: Mobile
Menu Enhancement
Posted by GitBox <gi...@apache.org>.
psingh587 edited a comment on issue #194: Mobile Menu Enhancement
URL: https://github.com/apache/camel-website/pull/194#issuecomment-597781519
> @zregvart this looks super clean :).
> But if we can include the search box now and like @psingh587 did in her PR #192 if now applied it will be a great achievement as per mobile screen navbar standard.
> what do you guys have to say @zregvart , @oscerd and @psingh587
> If this PR #194 gets merged.Then the work on PR #192 can be smoothly done and the main objective of PR #191 will be achieved. :)
I agree with @CSElonewolf here. I think there's a lot more scope to this one.
Also I think we can use the shorter logo for mobile screens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services