[GitHub] spark pull request #20419: [SPARK-23032][SQL][FOLLOW-UP]Add codegenStageId i...

[rednaxelafx <gi...@git.apache.org>]

Github user rednaxelafx commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20419#discussion_r167775177
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala ---
    @@ -1226,14 +1226,21 @@ class CodegenContext {
     
       /**
        * Register a comment and return the corresponding place holder
    +   *
    +   * @param placeholderId a string for a place holder
    --- End diff --
    
    Nit: can we rephrase this ScalaDoc a bit, maybe like:
    ```scala
    /**
     * ...
     * @param placeholderId an optionally specified identifier for the comment's placeholder. The caller should make sure this identifier is unique within the compilation unit. If this argument is not specified, a fresh identifier will be automatically created and used as the placeholder.
     * ...
     */
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org