[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #283: Add projectStrict for Dates and Timestamps

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #283: Add projectStrict for Dates and Timestamps
URL: https://github.com/apache/incubator-iceberg/pull/283#discussion_r306946343
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/expressions/ResidualEvaluator.java
 ##########
 @@ -211,31 +210,48 @@ public Expression or(Expression leftResult, Expression rightResult) {
         return pred; // not associated inclusive a partition field, can't be evaluated
       }
 
-      List<UnboundPredicate<?>> strictProjections = Lists.transform(parts,
-          part -> ((Transform<T, ?>) part.transform()).projectStrict(part.name(), pred));
+      for (PartitionField part : parts) {
 
 Review comment:
   I like how you restructured this to simply return `alwaysTrue` or `alwaysFalse` if any projection can determine the result. That's a lot simpler than before.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org