You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by bu...@apache.org on 2006/02/15 22:40:52 UTC

DO NOT REPLY [Bug 38664] New: - [pool] proposed PoolableObjectFactorys JavaDoc changes for 2.0

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38664>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38664

           Summary: [pool] proposed PoolableObjectFactorys JavaDoc changes
                    for 2.0
           Product: Commons
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Keywords: PatchAvailable
          Severity: enhancement
          Priority: P3
         Component: Pool
        AssignedTo: commons-dev@jakarta.apache.org
        ReportedBy: Sandy@McArthur.org


Attached are the pool 2.0 changes I'd like to see to the PoolableObjectFactory
and the KeyedPoolableObjectFactory interfaces. The noteworthy changes are:

* activateObject is to be invoked on previously idle objects, not object created
with makeObject.

* validateObject is to only be invoked on "active" objects. validateObject will
be called before the pool returns a borrowed object. The pool may call
validateObject when objects are being returned to the pool or by and idle
eviction code.

* no guarantee about the condition of objects passed to destroyObject method.
They could be active, passive, valid, or invalid.

* PoolableObjectFactorys must be thread-safe. The only promise an ObjectPool
makes is that the same instance of an object will not be passed to more than one
method of a PoolableObjectFactorys at a time.


For the last item I think we should provide a synchronization wrapper for
PoolableObjectFactorys much like java.util.Collections has a
synchronizedCollection method.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 38664] - [pool] proposed PoolableObjectFactorys JavaDoc changes for 2.0

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38664>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38664


rdonkin@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From rdonkin@apache.org  2006-02-18 20:23 -------
Committed. Many thanks.

I agree that a wrapper should be provided. Perhaps PoolUtils (like CollectionUtils)?

Robert

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 38664] - [pool] proposed PoolableObjectFactorys JavaDoc changes for 2.0

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38664>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38664





------- Additional Comments From Sandy@McArthur.org  2006-02-15 22:41 -------
Created an attachment (id=17706)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=17706&action=view)
PoolableObjectFactorys-javadoc.patch


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org