You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/07 07:14:57 UTC
[GitHub] [skywalking] heihei180 opened a new pull request, #9915: add component id for eventMesh java plugin.
heihei180 opened a new pull request, #9915:
URL: https://github.com/apache/skywalking/pull/9915
add component id for pr: https://github.com/apache/skywalking-java/pull/376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] heihei180 commented on a diff in pull request #9915: add component id for eventMesh java plugin.
Posted by GitBox <gi...@apache.org>.
heihei180 commented on code in PR #9915:
URL: https://github.com/apache/skywalking/pull/9915#discussion_r1018730187
##########
oap-server/server-starter/src/main/resources/component-libraries.yml:
##########
@@ -434,6 +434,15 @@ Impala-jdbc-driver:
Impala:
id: 134
languages: Java
+EventMesh:
+ id: 135
+ languages: Java
+eventmesh-producer:
+ id: 136
+ languages: Java
+eventmesh-consumer:
+ id: 137
+ languages: Java
Review Comment:
follow the style from activemq, if necessary ， i will chage it to: `eventMesh-producer`, `eventMesh-consumer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] heihei180 commented on pull request #9915: add component id for eventMesh java plugin.
Posted by GitBox <gi...@apache.org>.
heihei180 commented on PR #9915:
URL: https://github.com/apache/skywalking/pull/9915#issuecomment-1311265743
> Oops, you missed updating changes.md in the /docs/en/changes. Please fix it.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9915: add component id for eventMesh java plugin.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9915:
URL: https://github.com/apache/skywalking/pull/9915#discussion_r1015416774
##########
oap-server/server-starter/src/main/resources/component-libraries.yml:
##########
@@ -434,6 +434,15 @@ Impala-jdbc-driver:
Impala:
id: 134
languages: Java
+EventMesh:
+ id: 135
+ languages: Java
+eventmesh-producer:
+ id: 136
+ languages: Java
+eventmesh-consumer:
+ id: 137
+ languages: Java
Review Comment:
Would you keep the upper case and lower case consistent? These names seem very strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] heihei180 commented on a diff in pull request #9915: add component id for eventMesh java plugin.
Posted by GitBox <gi...@apache.org>.
heihei180 commented on code in PR #9915:
URL: https://github.com/apache/skywalking/pull/9915#discussion_r1015374395
##########
oap-server/server-starter/src/main/resources/component-libraries.yml:
##########
@@ -435,6 +435,10 @@ Impala:
id: 134
languages: Java
+EventMesh-producer:
Review Comment:
ok, thanks for your advice. I will write about both producers and consumers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] heihei180 commented on a diff in pull request #9915: add component id for eventMesh java plugin.
Posted by GitBox <gi...@apache.org>.
heihei180 commented on code in PR #9915:
URL: https://github.com/apache/skywalking/pull/9915#discussion_r1018730187
##########
oap-server/server-starter/src/main/resources/component-libraries.yml:
##########
@@ -434,6 +434,15 @@ Impala-jdbc-driver:
Impala:
id: 134
languages: Java
+EventMesh:
+ id: 135
+ languages: Java
+eventmesh-producer:
+ id: 136
+ languages: Java
+eventmesh-consumer:
+ id: 137
+ languages: Java
Review Comment:
follow the style from rocketmq, if necessary ， i will chage it to: `eventMesh-producer`, `eventMesh-consumer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9915: add component id for eventMesh java plugin.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9915:
URL: https://github.com/apache/skywalking/pull/9915#discussion_r1018743511
##########
oap-server/server-starter/src/main/resources/component-libraries.yml:
##########
@@ -434,6 +434,15 @@ Impala-jdbc-driver:
Impala:
id: 134
languages: Java
+EventMesh:
+ id: 135
+ languages: Java
+eventmesh-producer:
+ id: 136
+ languages: Java
+eventmesh-consumer:
+ id: 137
+ languages: Java
Review Comment:
OK, if that is not a mistake, I am fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9915: add component id for eventMesh java plugin.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9915:
URL: https://github.com/apache/skywalking/pull/9915#issuecomment-1305581216
The style is still wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9915: add component id for eventMesh java plugin.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9915:
URL: https://github.com/apache/skywalking/pull/9915#issuecomment-1309961722
Oops, you missed updating changes.md in the /docs/en/changes. Please fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9915: add component id for eventMesh java plugin.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9915:
URL: https://github.com/apache/skywalking/pull/9915#discussion_r1015157719
##########
oap-server/server-starter/src/main/resources/component-libraries.yml:
##########
@@ -435,6 +435,18 @@ Impala:
id: 134
languages: Java
+EventMesh:
+ id: 135
+ languages: Java
+
+eventmesh-producer:
+ id: 136
+ languages: Java
+
+eventmesh-consumer:
+ id: 137
+ languages: Java
Review Comment:
Please follow the formats. No empty lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9915: add component id for eventMesh java plugin.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9915:
URL: https://github.com/apache/skywalking/pull/9915#issuecomment-1308375180
Any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9915: add component id for eventMesh java plugin.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9915:
URL: https://github.com/apache/skywalking/pull/9915#discussion_r1015087795
##########
oap-server/server-starter/src/main/resources/component-libraries.yml:
##########
@@ -435,6 +435,10 @@ Impala:
id: 134
languages: Java
+EventMesh-producer:
Review Comment:
Could you explain why only producer? Where is consumer and server?
And why do you need producer rather than client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] heihei180 commented on pull request #9915: add component id for eventMesh java plugin.
Posted by GitBox <gi...@apache.org>.
heihei180 commented on PR #9915:
URL: https://github.com/apache/skywalking/pull/9915#issuecomment-1305590011
>
it's possible IntelliJ IDEA's settings have problem. wait a minute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] heihei180 commented on a diff in pull request #9915: add component id for eventMesh java plugin.
Posted by GitBox <gi...@apache.org>.
heihei180 commented on code in PR #9915:
URL: https://github.com/apache/skywalking/pull/9915#discussion_r1015092457
##########
oap-server/server-starter/src/main/resources/component-libraries.yml:
##########
@@ -435,6 +435,10 @@ Impala:
id: 134
languages: Java
+EventMesh-producer:
Review Comment:
i plan to enhance producer frist. ... i will enhance other togther
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9915: add component id for eventMesh java plugin.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9915:
URL: https://github.com/apache/skywalking/pull/9915#discussion_r1015156420
##########
oap-server/server-starter/src/main/resources/component-libraries.yml:
##########
@@ -435,6 +435,10 @@ Impala:
id: 134
languages: Java
+EventMesh-producer:
Review Comment:
As you are adding a tracing plugin, you have to do both sides, otherwise, the tracing context breaks, and ppl would feel confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #9915: add component id for eventMesh java plugin.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #9915:
URL: https://github.com/apache/skywalking/pull/9915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org