You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/23 12:43:23 UTC
[GitHub] [airflow] potiuk opened a new pull request, #23187: Use the new breeze in CI static checks
potiuk opened a new pull request, #23187:
URL: https://github.com/apache/airflow/pull/23187
* breeze static-checks is used in CI
* static-checks command is removed from ./breeze-legacy
* old bash pre-commit for static-checks is removed
* names are verified for existence in .pre-commit-config.yaml
* the names are used to generate documentation in STATIC_CODE_CHECKS.rst
* there is no more need to update STATIC_CODE_CHECKS.rst or
breeze-complete when new static check is added.
* The .pre-commmit-config.yaml file is a single source of truth for list
of static checks.
Fixes: #21099
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #23187: Use the new breeze in CI static checks
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #23187: Use the new breeze in CI static checks
URL: https://github.com/apache/airflow/pull/23187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23187: Use the new breeze in CI static checks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23187:
URL: https://github.com/apache/airflow/pull/23187#issuecomment-1107526935
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23187: Use the new breeze in CI static checks
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23187:
URL: https://github.com/apache/airflow/pull/23187#issuecomment-1107527226
This one needs #23189 to be merged - as I realized that return codes were wrongly propagated :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #23187: Use the new breeze in CI static checks
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #23187:
URL: https://github.com/apache/airflow/pull/23187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23187: Use the new breeze in CI static checks
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23187:
URL: https://github.com/apache/airflow/pull/23187#issuecomment-1107466010
cc: @edithturn @Bowrna -> yet another few hundred lines of bash code less (and @ephraimbuddy -> you'v added a few static checks recently, you should appreciate the improvement in automating everything. You just need to add pre-commit with name and then another pre-commit will take care about doing everything :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23187: Use the new breeze in CI static checks
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23187:
URL: https://github.com/apache/airflow/pull/23187#issuecomment-1107636950
just random failure, Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org