You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by pravin-dsilva <gi...@git.apache.org> on 2017/05/25 09:30:11 UTC
[GitHub] zeppelin pull request #2366: [ZEPPELIN-2471] - NotebookTest fails on travis
GitHub user pravin-dsilva opened a pull request:
https://github.com/apache/zeppelin/pull/2366
[ZEPPELIN-2471] - NotebookTest fails on travis
### What is this PR for?
The stacktrace for this issue gives the error:
```
06:31:15,263 ERROR org.apache.zeppelin.notebook.repo.VFSNotebookRepo:151 - Can't read note file:///tmp/ZeppelinLTest_1495261875233/notebook/2BQA35CJZ
com.google.gson.JsonSyntaxException: 2016-03-29T16:21:09-0700
```
This issue is related to notebooks failing to load with date ParseException and was fixed in ZEPPELIN-1129. However, in ZEPPELIN-2395 the fix for old format is excluded and hence the issue occurs again. Added the same code to fix the old date format issue in the fromJSON method of Note.java
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2471
### How should this be tested?
Tests should pass on CI
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pravin-dsilva/zeppelin ZEPPELIN-2471
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2366.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2366
----
commit 3a2e7884b0519afe1952b745729d2de20443415a
Author: pravin-dsilva <pr...@us.ibm.com>
Date: 2017-05-25T08:50:41Z
ZEPPELIN-2471 - NotebookTest fails on travis
commit d08320806f4d85ef31f7dc5c7f53210324b1d573
Author: pravin-dsilva <pr...@us.ibm.com>
Date: 2017-05-25T08:56:58Z
Update .travis.yml to include NotebookTest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2366: [ZEPPELIN-2471] - NotebookTest fails on travis
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2366
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2366: [ZEPPELIN-2471] - NotebookTest fails on travis
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2366
There's one test failure - could you take a look https://travis-ci.org/pravin-dsilva/zeppelin/jobs/235945509
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2366: [ZEPPELIN-2471] - NotebookTest fails on travis
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2366
Thanks @pravin-dsilva for the fix.
LGTM and merge to master if no further comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2366: [ZEPPELIN-2471] - NotebookTest fails on travis
Posted by pravin-dsilva <gi...@git.apache.org>.
Github user pravin-dsilva commented on the issue:
https://github.com/apache/zeppelin/pull/2366
The failure that i see is
```
test(org.apache.zeppelin.interpreter.InterpreterOutputChangeWatcherTest) Time elapsed: 2.034 sec <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<2>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at org.apache.zeppelin.interpreter.InterpreterOutputChangeWatcherTest.test(InterpreterOutputChangeWatcherTest.java:95)
```
This doesnt seem related to my change, but could anyone confirm this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---