You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/07/06 19:09:58 UTC

[GitHub] [storm] bipinprasad commented on a change in pull request #3302: [STORM-3666] Validate component name in rebalance command

bipinprasad commented on a change in pull request #3302:
URL: https://github.com/apache/storm/pull/3302#discussion_r450425745



##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -2676,6 +2676,14 @@ private void assertTopoActive(String topoName, boolean expectActive) throws NotA
         return tryReadTopoConf(topoId, topoCache);
     }
 
+    private StormTopology tryReadTopologyFromName(final String topoName) throws NotAliveException,
+            AuthorizationException, IOException {
+        IStormClusterState state = stormClusterState;

Review comment:
       Indeed. But looks like this idiom is widely used in Nimbus.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org