Re: [PR] IGNITE-27684 Update IGNITE_HEADER for discovery protocol [ignite]

["chesnokoff (via GitHub)" <gi...@apache.org>]

chesnokoff commented on code in PR #12671:
URL: https://github.com/apache/ignite/pull/12671#discussion_r2758728771


##########
modules/core/src/main/java/org/apache/ignite/internal/util/nio/GridConnectionBytesVerifyFilter.java:
##########
@@ -99,27 +99,27 @@ public GridConnectionBytesVerifyFilter(IgniteLogger log) {
 
         Integer magic = ses.meta(MAGIC_META_KEY);
 
-        if (magic == null || magic < U.IGNITE_HEADER.length) {
+        if (magic == null || magic < U.IGNITE_HEADER_V1.length) {
             byte[] magicBuf = ses.meta(MAGIC_BUF_KEY);
 
             if (magicBuf == null)
-                magicBuf = new byte[U.IGNITE_HEADER.length];
+                magicBuf = new byte[U.IGNITE_HEADER_V1.length];

Review Comment:
   The suggestion is to keep IGNITE_HEADER unchanged in the communication SPI and update it only in discovery. As I understand, this is not related to the discovery SPI



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org