You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/01/25 00:11:29 UTC
[GitHub] [kafka] lbradstreet opened a new pull request #11710: MINOR: MiniTrogdorCluster mutates objects from other threads
lbradstreet opened a new pull request #11710:
URL: https://github.com/apache/kafka/pull/11710
MiniTrogdorCluster spins up agents from a different thread when
scheduling them, but does not use volatiles in these objects. It's not
clear that the updated fields are visible.
The hope is that this will fix a failure where it test becomes stuck waiting for MiniTrogdorCluster to shutdown:
```
Suppressed: java.lang.InterruptedException
at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:2014)
at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2088)
at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1475)
at java.util.concurrent.Executors$DelegatedExecutorService.awaitTermination(Executors.java:675)
at org.apache.kafka.trogdor.coordinator.TaskManager.waitForShutdown(TaskManager.java:699)
at org.apache.kafka.trogdor.coordinator.Coordinator.waitForShutdown(Coordinator.java:133)
at org.apache.kafka.trogdor.common.MiniTrogdorCluster.close(MiniTrogdorCluster.java:289)
at org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated(CoordinatorTest.java:595)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:688)
at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
at org.junit.jupiter.engine.extension.TimeoutInvocation.proceed(TimeoutInvocation.java:46)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #11710: MINOR: MiniTrogdorCluster mutates objects from other threads
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #11710:
URL: https://github.com/apache/kafka/pull/11710#issuecomment-1020677668
It would be nice to redo this without the volatiles, but for now, LGTM. Thanks, @lbradstreet .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #11710: MINOR: MiniTrogdorCluster mutates objects from other threads
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #11710:
URL: https://github.com/apache/kafka/pull/11710#issuecomment-1020677668
It would be nice to redo this without the volatiles, but for now, LGTM. Thanks, @lbradstreet .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac merged pull request #11710: MINOR: MiniTrogdorCluster mutates objects from other threads
Posted by GitBox <gi...@apache.org>.
dajac merged pull request #11710:
URL: https://github.com/apache/kafka/pull/11710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org