You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by pujav65 <gi...@git.apache.org> on 2016/07/21 12:33:21 UTC

[GitHub] incubator-rya pull request #54: RYA-100 Added Maven animal-sniffer plugin to...

Github user pujav65 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/54#discussion_r71696281
  
    --- Diff: pom.xml ---
    @@ -562,6 +562,29 @@ under the License.
                             <target>1.7</target>
                         </configuration>
                     </plugin>
    +
    +                <!-- Fail a build if it uses any Java features introduced after 1.7. -->
    +                <plugin>
    +                    <groupId>org.codehaus.mojo</groupId>
    +                    <artifactId>animal-sniffer-maven-plugin</artifactId>
    +                    <version>1.15</version>
    +                    <configuration>
    +                        <signature>
    +                            <groupId>org.codehaus.mojo.signature</groupId>
    +                            <artifactId>java17</artifactId>
    --- End diff --
    
    I think a later pull request upgrades rya back to java 8 (an upgrade that was lost somehow when we ported to apache).  Can you update this accordingly?  Then I will merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---