You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sean Busbey <se...@manvsbeard.com> on 2012/10/04 05:11:44 UTC

Re: Review Request: HIVE-3525

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7430/
-----------------------------------------------------------

(Updated Oct. 4, 2012, 3:11 a.m.)


Review request for hive.


Changes
-------

Now includes a proposed fix, changing internal Hashtable use to HashMap.


Summary (updated)
-----------------

HIVE-3525


Description (updated)
-------

Changes Avro SerDe to use HashMap when copying out the Avro Map<Utf8, Object> to Map<String, Object>. fixes HIVE-3525.


Diffs (updated)
-----

  /trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java 1393805 
  /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroDeserializer.java 1393805 
  /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroObjectInspectorGenerator.java 1393805 
  /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerializer.java 1393805 

Diff: https://reviews.apache.org/r/7430/diff/


Testing (updated)
-------

Includes unit tests for 

* AvroObjectInspectorGenerator to verify that the Nullable value type is presented as just the non-null type.
* AvroDeserializer to verify that Maps with null are properly handled
* AvroSerializer to verify that Maps with null can round trip.


Thanks,

Sean Busbey

Re: Review Request: HIVE-3525

Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7430/
-----------------------------------------------------------

(Updated Oct. 4, 2012, 1:56 p.m.)


Review request for hive.


Changes
-------

Last update missed the changes to AvroSerializer


Description
-------

Changes Avro SerDe to use HashMap when copying out the Avro Map<Utf8, Object> to Map<String, Object>. fixes HIVE-3525.


Diffs (updated)
-----

  /trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java 1394076 
  /trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java 1394076 
  /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroDeserializer.java 1394076 
  /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroObjectInspectorGenerator.java 1394076 
  /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerializer.java 1394076 

Diff: https://reviews.apache.org/r/7430/diff/


Testing
-------

Includes unit tests for 

* AvroObjectInspectorGenerator to verify that the Nullable value type is presented as just the non-null type.
* AvroDeserializer to verify that Maps with null are properly handled
* AvroSerializer to verify that Maps with null can round trip.


Thanks,

Sean Busbey