You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/31 09:20:01 UTC

[GitHub] [incubator-apisix] jackwoods opened a new pull request #1959: feature: accept ":" in id (#1955)

jackwoods opened a new pull request #1959:
URL: https://github.com/apache/incubator-apisix/pull/1959


   ### What this PR does / why we need it:
   Sometimes we might hope the id in the following format: 
   - upstream:payment:project_a
   - upstream:message_system:project_b
   etc.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1959: feature: accept ":" in id (#1955)

Posted by GitBox <gi...@apache.org>.

membphis commented on pull request #1959:
URL: https://github.com/apache/incubator-apisix/pull/1959#issuecomment-667089765


   @jackwoods That is the right way, I have helped you updated.
   
   ![image](https://user-images.githubusercontent.com/6814606/89033857-55574c00-d36a-11ea-99d5-1b6b12af27af.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] moonming commented on pull request #1959: feature: accept ":" in id (#1955)

Posted by GitBox <gi...@apache.org>.

moonming commented on pull request #1959:
URL: https://github.com/apache/incubator-apisix/pull/1959#issuecomment-667045981


   @jackwoods please add test cases


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org