You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/24 14:28:00 UTC

[GitHub] [shardingsphere] linghengqian opened a new pull request, #17919: Add support for more JSR-310 related classes about JDBC Date and JDBC Time in IntervalShardingAlgorithm

linghengqian opened a new pull request, #17919:
URL: https://github.com/apache/shardingsphere/pull/17919

   For #17752.
   
   Changes proposed in this pull request:
   - Added support for `java.time.LocalTime`, `java.time.OffsetTime`, `java.time.LocalDate`, `java.time.chrono.JapaneseDate` in `org.apache.shardingsphere.sharding.algorithm.sharding.datetime.IntervalShardingAlgorithm`.
   - Added unit tests for `java.time.LocalTime`, `java.time.OffsetTime`, `java.time.LocalDate` in `org.apache.shardingsphere.sharding.algorithm.sharding.datetime.IntervalShardingAlgorithmTest`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #17919: Add support for more JSR-310 related classes about JDBC Date and JDBC Time in IntervalShardingAlgorithm

Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #17919:
URL: https://github.com/apache/shardingsphere/pull/17919


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #17919: Add support for more JSR-310 related classes about JDBC Date and JDBC Time in IntervalShardingAlgorithm

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17919:
URL: https://github.com/apache/shardingsphere/pull/17919#issuecomment-1136127670

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17919?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#17919](https://codecov.io/gh/apache/shardingsphere/pull/17919?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21f16ba) into [master](https://codecov.io/gh/apache/shardingsphere/commit/55c26fbe247bd3fcf34877dadeb406b9c7c7e722?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (55c26fb) will **decrease** coverage by `0.04%`.
   > The diff coverage is `40.21%`.
   
   > :exclamation: Current head 21f16ba differs from pull request most recent head defa8f5. Consider uploading reports for the commit defa8f5 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17919      +/-   ##
   ============================================
   - Coverage     59.20%   59.15%   -0.05%     
   - Complexity     2134     2136       +2     
   ============================================
     Files          3604     3616      +12     
     Lines         53432    53571     +139     
     Branches       9111     9146      +35     
   ============================================
   + Hits          31632    31690      +58     
   - Misses        19119    19188      +69     
   - Partials       2681     2693      +12     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17919?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/ShardingRuleAlteredJobConfigurationPreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/17919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvZGF0YS9waXBlbGluZS9TaGFyZGluZ1J1bGVBbHRlcmVkSm9iQ29uZmlndXJhdGlvblByZXBhcmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...adcast/ShardingInstanceBroadcastRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/17919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3R5cGUvYnJvYWRjYXN0L1NoYXJkaW5nSW5zdGFuY2VCcm9hZGNhc3RSb3V0aW5nRW5naW5lLmphdmE=) | `83.33% <0.00%> (ø)` | |
   | [...data/type/hikari/HikariDataSourcePoolMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/17919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Bvb2wvbWV0YWRhdGEvdHlwZS9oaWthcmkvSGlrYXJpRGF0YVNvdXJjZVBvb2xNZXRhRGF0YS5qYXZh) | `100.00% <ø> (ø)` | |
   | [...gsphere/infra/metadata/ShardingSphereDatabase.java](https://codecov.io/gh/apache/shardingsphere/pull/17919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9TaGFyZGluZ1NwaGVyZURhdGFiYXNlLmphdmE=) | `7.69% <0.00%> (+2.93%)` | :arrow_up: |
   | [...nfra/metadata/rule/ShardingSphereRuleMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/17919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9ydWxlL1NoYXJkaW5nU3BoZXJlUnVsZU1ldGFEYXRhLmphdmE=) | `37.50% <0.00%> (ø)` | |
   | [...ere/infra/metadata/schema/loader/SchemaLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/17919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvbG9hZGVyL1NjaGVtYUxvYWRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gment/expression/impl/ListExpressionConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/17919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLW9wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvZmVkZXJhdGlvbi9vcHRpbWl6ZXIvY29udmVydGVyL3NlZ21lbnQvZXhwcmVzc2lvbi9pbXBsL0xpc3RFeHByZXNzaW9uQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...re/infra/parser/ShardingSphereSQLParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/17919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcGFyc2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9wYXJzZXIvU2hhcmRpbmdTcGhlcmVTUUxQYXJzZXJFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...eator/ShardingSpherePipelineDataSourceCreator.java](https://codecov.io/gh/apache/shardingsphere/pull/17919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9kYXRhL3BpcGVsaW5lL2RhdGFzb3VyY2UvY3JlYXRvci9TaGFyZGluZ1NwaGVyZVBpcGVsaW5lRGF0YVNvdXJjZUNyZWF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/driver/jdbc/adapter/AdaptedDatabaseMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/17919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2FkYXB0ZXIvQWRhcHRlZERhdGFiYXNlTWV0YURhdGEuamF2YQ==) | `99.31% <ø> (ø)` | |
   | ... and [92 more](https://codecov.io/gh/apache/shardingsphere/pull/17919/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17919?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17919?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [55c26fb...defa8f5](https://codecov.io/gh/apache/shardingsphere/pull/17919?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] linghengqian commented on pull request #17919: Add support for more JSR-310 related classes about JDBC Date and JDBC Time in IntervalShardingAlgorithm

Posted by GitBox <gi...@apache.org>.
linghengqian commented on PR #17919:
URL: https://github.com/apache/shardingsphere/pull/17919#issuecomment-1136026115

   Due to my unfamiliarity with `java.time.chrono.JapaneseDate`, its `java.time.format.DateTimeFormatter` looks like `DateTimeFormatter.ofPattern("Gy年MM月dd日")`, I can't use my knowledge Building unit tests, I'll ask for help in the original issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org