You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/02/22 00:39:10 UTC
Review Request 65743: Ensured that Docker containerizer returns a
failed Future in one case.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65743/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
Bugs: MESOS-8575
https://issues.apache.org/jira/browse/MESOS-8575
Repository: mesos
Description
-------
Because the Docker library did not immediately transition the
Future returned by `inspect()` to DISCARDED, it was safe for the
Docker containerizer to discard this Future before failing the
Promise associated with the Future returned by `launch()`.
However, the introduction of an `onDiscard` callback in
`Docker::inspect()` makes this assumption invalid. This patch
addresses this by failing the Promise before discarding the
Future.
Diffs
-----
src/slave/containerizer/docker.cpp 7585178f34bdb782f0108d3ab94c23edfacc5564
Diff: https://reviews.apache.org/r/65743/diff/1/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 65743: Ensured that Docker containerizer returns a
failed Future in one case.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65743/
-----------------------------------------------------------
(Updated Feb. 28, 2018, 1:36 a.m.)
Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
Bugs: MESOS-8576
https://issues.apache.org/jira/browse/MESOS-8576
Repository: mesos
Description
-------
Because the Docker library did not immediately transition the
Future returned by `inspect()` to DISCARDED, it was safe for the
Docker containerizer to discard this Future before failing the
Promise associated with the Future returned by `launch()`.
However, the introduction of an `onDiscard` callback in
`Docker::inspect()` makes this assumption invalid. This patch
addresses this by failing the Promise before discarding the
Future.
Diffs
-----
src/slave/containerizer/docker.cpp 7585178f34bdb782f0108d3ab94c23edfacc5564
Diff: https://reviews.apache.org/r/65743/diff/1/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 65743: Ensured that Docker containerizer returns a
failed Future in one case.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65743/
-----------------------------------------------------------
(Updated Feb. 28, 2018, 1:04 a.m.)
Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
Bugs: MESOS-8576
https://issues.apache.org/jira/browse/MESOS-8576
Repository: mesos
Description
-------
Because the Docker library did not immediately transition the
Future returned by `inspect()` to DISCARDED, it was safe for the
Docker containerizer to discard this Future before failing the
Promise associated with the Future returned by `launch()`.
However, the introduction of an `onDiscard` callback in
`Docker::inspect()` makes this assumption invalid. This patch
addresses this by failing the Promise before discarding the
Future.
Diffs
-----
src/slave/containerizer/docker.cpp 7585178f34bdb782f0108d3ab94c23edfacc5564
Diff: https://reviews.apache.org/r/65743/diff/1/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 65743: Ensured that Docker containerizer returns a
failed Future in one case.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65743/#review198084
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 65683.
Failed command: `python.exe .\support\apply-reviews.py -n -r 65683`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65743
Relevant logs:
- [apply-review-65683-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65743/logs/apply-review-65683-stdout.log):
```
error: patch failed: src/docker/docker.cpp:1308
error: src/docker/docker.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On Feb. 22, 2018, 12:39 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65743/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2018, 12:39 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Bugs: MESOS-8575
> https://issues.apache.org/jira/browse/MESOS-8575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Because the Docker library did not immediately transition the
> Future returned by `inspect()` to DISCARDED, it was safe for the
> Docker containerizer to discard this Future before failing the
> Promise associated with the Future returned by `launch()`.
>
> However, the introduction of an `onDiscard` callback in
> `Docker::inspect()` makes this assumption invalid. This patch
> addresses this by failing the Promise before discarding the
> Future.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 7585178f34bdb782f0108d3ab94c23edfacc5564
>
>
> Diff: https://reviews.apache.org/r/65743/diff/1/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65743: Ensured that Docker containerizer returns a
failed Future in one case.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65743/#review198191
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Feb. 21, 2018, 4:39 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65743/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 4:39 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Bugs: MESOS-8575
> https://issues.apache.org/jira/browse/MESOS-8575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Because the Docker library did not immediately transition the
> Future returned by `inspect()` to DISCARDED, it was safe for the
> Docker containerizer to discard this Future before failing the
> Promise associated with the Future returned by `launch()`.
>
> However, the introduction of an `onDiscard` callback in
> `Docker::inspect()` makes this assumption invalid. This patch
> addresses this by failing the Promise before discarding the
> Future.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 7585178f34bdb782f0108d3ab94c23edfacc5564
>
>
> Diff: https://reviews.apache.org/r/65743/diff/1/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65743: Ensured that Docker containerizer returns a
failed Future in one case.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65743/#review198085
-----------------------------------------------------------
Bad patch!
Reviews applied: [65743, 65683]
Failed command: python support/apply-reviews.py -n -r 65683
Error:
2018-02-22 01:06:40 URL:https://reviews.apache.org/r/65683/diff/raw/ [2168/2168] -> "65683.patch" [1]
error: patch failed: src/docker/docker.cpp:1308
error: src/docker/docker.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/21723/console
- Mesos Reviewbot
On Feb. 22, 2018, 12:39 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65743/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2018, 12:39 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Bugs: MESOS-8575
> https://issues.apache.org/jira/browse/MESOS-8575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Because the Docker library did not immediately transition the
> Future returned by `inspect()` to DISCARDED, it was safe for the
> Docker containerizer to discard this Future before failing the
> Promise associated with the Future returned by `launch()`.
>
> However, the introduction of an `onDiscard` callback in
> `Docker::inspect()` makes this assumption invalid. This patch
> addresses this by failing the Promise before discarding the
> Future.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 7585178f34bdb782f0108d3ab94c23edfacc5564
>
>
> Diff: https://reviews.apache.org/r/65743/diff/1/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65743: Ensured that Docker containerizer returns a
failed Future in one case.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65743/#review198182
-----------------------------------------------------------
Ship it!
Ship It!
- Andrei Budnik
On Feb. 22, 2018, 12:39 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65743/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2018, 12:39 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Bugs: MESOS-8575
> https://issues.apache.org/jira/browse/MESOS-8575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Because the Docker library did not immediately transition the
> Future returned by `inspect()` to DISCARDED, it was safe for the
> Docker containerizer to discard this Future before failing the
> Promise associated with the Future returned by `launch()`.
>
> However, the introduction of an `onDiscard` callback in
> `Docker::inspect()` makes this assumption invalid. This patch
> addresses this by failing the Promise before discarding the
> Future.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 7585178f34bdb782f0108d3ab94c23edfacc5564
>
>
> Diff: https://reviews.apache.org/r/65743/diff/1/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>