You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jesús Camacho Rodríguez <jc...@hortonworks.com> on 2018/10/19 00:19:00 UTC
Review Request 69078: HIVE-20767
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69078/
-----------------------------------------------------------
Review request for hive, Ashutosh Chauhan and Vineet Garg.
Bugs: HIVE-20767
https://issues.apache.org/jira/browse/HIVE-20767
Repository: hive-git
Description
-------
HIVE-20767
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java e6844326068210e7ab7364ec9f3ec60908b36e88
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 22f3266c87f1d42c254893b424b68e757fb2953b
ql/src/test/results/clientnegative/subquery_scalar_multi_rows.q.out 0a780db7ef98ddf14fc18a90f2b628a13337bcda
ql/src/test/results/clientpositive/bool_unknown.q.out 8e9b48ccafce2093e91d7035fdf581018bab1979
ql/src/test/results/clientpositive/llap/lineage2.q.out d32f490a704e1ba6bdc54f4d54dff028c9ca974c
ql/src/test/results/clientpositive/llap/mapjoin_hint.q.out ac505a5c1e47211260a795390a3ca7c45ee30c01
ql/src/test/results/clientpositive/llap/materialized_view_rewrite_7.q.out 6f00a5c82b2c2784d2576222d6eb4bd9faf71bea
ql/src/test/results/clientpositive/llap/multiMapJoin1.q.out ae821f600b3e9bf3128e93c0a4097b438f26f35b
ql/src/test/results/clientpositive/llap/subquery_scalar.q.out 166bd60ce25712021c06d3506246ff87d35058c4
ql/src/test/results/clientpositive/llap/subquery_select.q.out 854d215a2382e5b09714c7b8b9916cf048458f66
ql/src/test/results/clientpositive/perf/spark/query54.q.out f10250f307cc58486dbb202c95b2c8af7943e528
ql/src/test/results/clientpositive/perf/tez/query54.q.out 1c17d2a53a1be39b28d01412fe6b13878b1680f3
ql/src/test/results/clientpositive/spark/subquery_scalar.q.out b3252f54158d5401c3d10b0978af69b9dbba1290
ql/src/test/results/clientpositive/spark/subquery_select.q.out ad7c8a3fc795004ea5dbd2bc4355de24b73352be
Diff: https://reviews.apache.org/r/69078/diff/1/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 69078: HIVE-20767
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69078/#review209775
-----------------------------------------------------------
ql/src/test/results/clientpositive/llap/mapjoin_hint.q.out
Lines 469-470 (original), 470-472 (patched)
<https://reviews.apache.org/r/69078/#comment294348>
This plan looks slower than previous with extra shuffle.
ql/src/test/results/clientpositive/llap/subquery_scalar.q.out
Lines 240-241 (original), 242-244 (patched)
<https://reviews.apache.org/r/69078/#comment294349>
This plan looks slower than previous with extra shuffle.
ql/src/test/results/clientpositive/llap/subquery_scalar.q.out
Line 1005 (original), 1038 (patched)
<https://reviews.apache.org/r/69078/#comment294350>
This plan looks slower than previous with extra shuffle.
ql/src/test/results/clientpositive/llap/subquery_select.q.out
Lines 4905-4907 (original), 4905-4907 (patched)
<https://reviews.apache.org/r/69078/#comment294351>
This plan looks slower than previous with extra shuffle.
- Ashutosh Chauhan
On Oct. 19, 2018, 12:18 a.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69078/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2018, 12:18 a.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Vineet Garg.
>
>
> Bugs: HIVE-20767
> https://issues.apache.org/jira/browse/HIVE-20767
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20767
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java e6844326068210e7ab7364ec9f3ec60908b36e88
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 22f3266c87f1d42c254893b424b68e757fb2953b
> ql/src/test/results/clientnegative/subquery_scalar_multi_rows.q.out 0a780db7ef98ddf14fc18a90f2b628a13337bcda
> ql/src/test/results/clientpositive/bool_unknown.q.out 8e9b48ccafce2093e91d7035fdf581018bab1979
> ql/src/test/results/clientpositive/llap/lineage2.q.out d32f490a704e1ba6bdc54f4d54dff028c9ca974c
> ql/src/test/results/clientpositive/llap/mapjoin_hint.q.out ac505a5c1e47211260a795390a3ca7c45ee30c01
> ql/src/test/results/clientpositive/llap/materialized_view_rewrite_7.q.out 6f00a5c82b2c2784d2576222d6eb4bd9faf71bea
> ql/src/test/results/clientpositive/llap/multiMapJoin1.q.out ae821f600b3e9bf3128e93c0a4097b438f26f35b
> ql/src/test/results/clientpositive/llap/subquery_scalar.q.out 166bd60ce25712021c06d3506246ff87d35058c4
> ql/src/test/results/clientpositive/llap/subquery_select.q.out 854d215a2382e5b09714c7b8b9916cf048458f66
> ql/src/test/results/clientpositive/perf/spark/query54.q.out f10250f307cc58486dbb202c95b2c8af7943e528
> ql/src/test/results/clientpositive/perf/tez/query54.q.out 1c17d2a53a1be39b28d01412fe6b13878b1680f3
> ql/src/test/results/clientpositive/spark/subquery_scalar.q.out b3252f54158d5401c3d10b0978af69b9dbba1290
> ql/src/test/results/clientpositive/spark/subquery_select.q.out ad7c8a3fc795004ea5dbd2bc4355de24b73352be
>
>
> Diff: https://reviews.apache.org/r/69078/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 69078: HIVE-20767
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69078/
-----------------------------------------------------------
(Updated Oct. 19, 2018, 4:12 p.m.)
Review request for hive, Ashutosh Chauhan and Vineet Garg.
Summary (updated)
-----------------
HIVE-20767
Bugs: HIVE-20767
https://issues.apache.org/jira/browse/HIVE-20767
Repository: hive-git
Description (updated)
-------
HIVE-20767
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java e6844326068210e7ab7364ec9f3ec60908b36e88
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 22f3266c87f1d42c254893b424b68e757fb2953b
ql/src/test/results/clientpositive/llap/lineage2.q.out d32f490a704e1ba6bdc54f4d54dff028c9ca974c
ql/src/test/results/clientpositive/llap/materialized_view_rewrite_7.q.out 6f00a5c82b2c2784d2576222d6eb4bd9faf71bea
ql/src/test/results/clientpositive/llap/multiMapJoin1.q.out ae821f600b3e9bf3128e93c0a4097b438f26f35b
ql/src/test/results/clientpositive/perf/spark/query54.q.out f10250f307cc58486dbb202c95b2c8af7943e528
ql/src/test/results/clientpositive/perf/tez/query54.q.out 1c17d2a53a1be39b28d01412fe6b13878b1680f3
Diff: https://reviews.apache.org/r/69078/diff/3/
Changes: https://reviews.apache.org/r/69078/diff/2-3/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 69078: HIVE-20720: Add partition column option to
JDBC handler (Daniel Dai, reviewed by Jesus Camacho Rodriguez)
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69078/
-----------------------------------------------------------
(Updated Oct. 19, 2018, 4:11 p.m.)
Review request for hive, Ashutosh Chauhan and Vineet Garg.
Summary (updated)
-----------------
HIVE-20720: Add partition column option to JDBC handler (Daniel Dai, reviewed by Jesus Camacho Rodriguez)
Bugs: HIVE-20767
https://issues.apache.org/jira/browse/HIVE-20767
Repository: hive-git
Description (updated)
-------
Signed-off-by: Jesus Camacho Rodriguez <jc...@apache.org>
HIVE-20549: Allow user set query tag, and kill query with tag (Daniel Dai, reviewed by Thejas Nair, Sergey Shelukhin)
Signed-off-by: Thejas M Nair <th...@hortonworks.com>, sergey <se...@apache.org>
HIVE-20742: SparkSessionManagerImpl maintenance thread only cleans up session once (Antal Sinkovits reviewed by Sahil Takiar and Peter Vary)
HIVE-20767
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/Constants.java 11906797e42c106eb5731983129825390c8b09fc
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8a06cb505b24ff85c36dfb78f7bbf6c92b53bc07
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/exec/spark/TestSparkSessionTimeout.java d8dd80a1c2e7f9c597ec65b2809dc68de7db43bc
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniLlapArrow.java e125ba3de4a1db79759d648407eeb4a8b6c4526d
itests/src/test/resources/testconfiguration.properties b6d42c64af002aa37a9c088dea8ea6b41c96c950
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/JdbcInputFormat.java 74999db88df0b4e0ef6ca92c5ff2e958146d68e8
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/JdbcInputSplit.java 3a6ada80c59e6d3e2c40746cf991e1157f8eff21
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/JdbcRecordReader.java 1da6213ed4ab89c85f76cd1366011b6b85b98c3f
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/JdbcSerDe.java 5947628de80e816d44cfedf842354f85918f9bec
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/conf/JdbcStorageConfigManager.java 18e239786d4bc5be372f21545f726b62becf7392
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/DatabaseAccessor.java fdaa79482967265d4c3b711bfa1e82c6334d861a
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/GenericJdbcDatabaseAccessor.java abdc5f048cc728701570a9eb229e7233b78cac0c
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/JdbcRecordIterator.java a95aca21583281ad22b6350594e4accc0fe4408d
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/JethroDatabaseAccessor.java db0454ea358db0d9a44123d0c3c93a21ec45beb4
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/MySqlDatabaseAccessor.java 86fde7c9650b97de309238f58b45573209a3c0ed
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/spitter/DateIntervalSplitter.java PRE-CREATION
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/spitter/DecimalIntervalSplitter.java PRE-CREATION
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/spitter/DoubleIntervalSplitter.java PRE-CREATION
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/spitter/IntervalSplitter.java PRE-CREATION
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/spitter/IntervalSplitterFactory.java PRE-CREATION
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/spitter/LongIntervalSpitter.java PRE-CREATION
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/spitter/TimestampIntervalSplitter.java PRE-CREATION
jdbc-handler/src/test/java/org/apache/hive/storage/jdbc/TestJdbcInputFormat.java b146633c50101ef09412a113fa2029ea51545e28
jdbc-handler/src/test/java/org/apache/hive/storage/jdbc/dao/TestGenericJdbcDatabaseAccessor.java 34f061ee1388fe05924eee6df4186b4d905921f4
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 6990be0881401022557d7aa10ff8f11c91134458
ql/src/java/org/apache/hadoop/hive/ql/QueryState.java 028dd6017d5bfb0a615e5a2e781c117eba323566
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManagerImpl.java 8dae54d7bd823eb4dfd75b15b707477f271161ca
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/KillTriggerActionHandler.java f357775c866578b408fb2c606c09fc0d840d3367
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 5326e3590ff45093ac1e147ebb7a853414ccb538
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java e6844326068210e7ab7364ec9f3ec60908b36e88
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 22f3266c87f1d42c254893b424b68e757fb2953b
ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java 87c69cfb2552ab54168b762da7f9f1a5fb5e6264
ql/src/test/queries/clientnegative/authorization_kill_query.q 5379f877644a79611cc1ffc9c6b9cc18df795d97
ql/src/test/queries/clientpositive/external_jdbc_table_partition.q PRE-CREATION
ql/src/test/queries/clientpositive/external_jdbc_table_typeconversion.q PRE-CREATION
ql/src/test/results/clientpositive/llap/external_jdbc_table_partition.q.out PRE-CREATION
ql/src/test/results/clientpositive/llap/external_jdbc_table_typeconversion.q.out PRE-CREATION
ql/src/test/results/clientpositive/llap/lineage2.q.out d32f490a704e1ba6bdc54f4d54dff028c9ca974c
ql/src/test/results/clientpositive/llap/materialized_view_rewrite_7.q.out 6f00a5c82b2c2784d2576222d6eb4bd9faf71bea
ql/src/test/results/clientpositive/llap/multiMapJoin1.q.out ae821f600b3e9bf3128e93c0a4097b438f26f35b
ql/src/test/results/clientpositive/perf/spark/query54.q.out f10250f307cc58486dbb202c95b2c8af7943e528
ql/src/test/results/clientpositive/perf/tez/query54.q.out 1c17d2a53a1be39b28d01412fe6b13878b1680f3
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 8db6a297df33fbd09f00cca2bcc98a477a54b9ff
service/src/java/org/apache/hive/service/server/KillQueryImpl.java 490a04da675bcc2090982c11a789e0c21fce346e
Diff: https://reviews.apache.org/r/69078/diff/2/
Changes: https://reviews.apache.org/r/69078/diff/1-2/
Testing
-------
Thanks,
Jesús Camacho Rodríguez