You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "phongn (via GitHub)" <gi...@apache.org> on 2023/11/29 01:08:10 UTC
[PR] Replace nonstandard darwin platform detection [trafficserver]
phongn opened a new pull request, #10864:
URL: https://github.com/apache/trafficserver/pull/10864
We do not a few feature checks for operating systems using deprecated flags. This replaces the nonstandard `darwin` with `__APPLE__` ⋀ `__MACH__`.
A future PR will do so for FreeBSD and OpenBSD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replace nonstandard darwin platform detection [trafficserver]
Posted by "randall (via GitHub)" <gi...@apache.org>.
randall commented on code in PR #10864:
URL: https://github.com/apache/trafficserver/pull/10864#discussion_r1408680027
##########
src/iocore/net/test_certlookup.cc:
##########
@@ -234,7 +234,7 @@ main(int argc, const char **argv)
ink_freelists_dump(stdout);
// On Darwin, fail the tests if we have any memory leaks.
Review Comment:
Maybe change the deferences to Darwin in comments to macOS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replace nonstandard darwin platform detection [trafficserver]
Posted by "phongn (via GitHub)" <gi...@apache.org>.
phongn closed pull request #10864: Replace nonstandard darwin platform detection
URL: https://github.com/apache/trafficserver/pull/10864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replace nonstandard darwin platform detection [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #10864:
URL: https://github.com/apache/trafficserver/pull/10864#issuecomment-1841769354
We do define `darwin`, is that not working? Why do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replace nonstandard darwin platform detection [trafficserver]
Posted by "phongn (via GitHub)" <gi...@apache.org>.
phongn commented on code in PR #10864:
URL: https://github.com/apache/trafficserver/pull/10864#discussion_r1408711509
##########
src/iocore/net/test_certlookup.cc:
##########
@@ -234,7 +234,7 @@ main(int argc, const char **argv)
ink_freelists_dump(stdout);
// On Darwin, fail the tests if we have any memory leaks.
Review Comment:
I thought about it, but it's not actually wrong either (and `uname` returns `Darwin` on macOS). It's really just the preprocessor directives that should be changed. Also, a number of places look for the `Darwin` string as well for various purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org