You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tg...@apache.org on 2017/04/22 02:01:12 UTC

[1/2] beam git commit: This closes #2641

Repository: beam
Updated Branches:
  refs/heads/master 781c15522 -> 459630ec8


This closes #2641


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/459630ec
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/459630ec
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/459630ec

Branch: refs/heads/master
Commit: 459630ec8754794a53c9848f871b907f1f4a10e0
Parents: 781c155 e8f28dd
Author: Thomas Groh <tg...@google.com>
Authored: Fri Apr 21 19:01:01 2017 -0700
Committer: Thomas Groh <tg...@google.com>
Committed: Fri Apr 21 19:01:01 2017 -0700

----------------------------------------------------------------------
 .../src/main/java/org/apache/beam/sdk/util/PCollectionViews.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------



[2/2] beam git commit: Make SimplePCollectionView Visible

Posted by tg...@apache.org.
Make SimplePCollectionView Visible

View will be replaced as a marker interface. Runners can expect to
always recieve a subclass of SimplePCollectionView, and cast to it when
methods are required.


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/e8f28dd4
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/e8f28dd4
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/e8f28dd4

Branch: refs/heads/master
Commit: e8f28dd477c2404ebfd26d08b87340a7eea6525c
Parents: 781c155
Author: Thomas Groh <tg...@google.com>
Authored: Fri Apr 21 09:46:28 2017 -0700
Committer: Thomas Groh <tg...@google.com>
Committed: Fri Apr 21 19:01:01 2017 -0700

----------------------------------------------------------------------
 .../src/main/java/org/apache/beam/sdk/util/PCollectionViews.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/e8f28dd4/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PCollectionViews.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PCollectionViews.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PCollectionViews.java
index 14b36fd..f2052ac 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PCollectionViews.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PCollectionViews.java
@@ -341,8 +341,10 @@ public class PCollectionViews {
   /**
    * A class for {@link PCollectionView} implementations, with additional type parameters
    * that are not visible at pipeline assembly time when the view is used as a side input.
+   *
+   * <p>For internal use only.
    */
-  private static class SimplePCollectionView<ElemT, ViewT, W extends BoundedWindow>
+  public static class SimplePCollectionView<ElemT, ViewT, W extends BoundedWindow>
       extends PValueBase
       implements PCollectionView<ViewT> {
     /** The {@link PCollection} this view was originally created from. */