You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/08 23:29:00 UTC
[jira] [Work logged] (BEAM-4255) GloballyAsSingletonView is writing
multiple values to the SingletonView
[ https://issues.apache.org/jira/browse/BEAM-4255?focusedWorklogId=99792&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-99792 ]
ASF GitHub Bot logged work on BEAM-4255:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/18 23:28
Start Date: 08/May/18 23:28
Worklog Time Spent: 10m
Work Description: huygaa11 opened a new pull request #5311: [BEAM-4255] Set singleton view writers' accumulation mode to discarding
URL: https://github.com/apache/beam/pull/5311
The code snippet below was writing multiple values to the sideInput, resulting in exception: "PCollection with more than one element accessed as a singleton view."
PCollectionView<Integer> globalView = input
.apply(Window.<Integer>into(new GlobalWindows())
.triggering(Repeatedly.forever(AfterPane.elementCountAtLeast(1)))
.accumulatingFiredPanes())
.apply(Sum.integersGlobally().asSingletonView())
This PR sets the accumulation mode to discarding for singleton view writer, so that the GBK's used by view writers do not accumulate combine results.
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand:
- [ ] What the pull request does
- [ ] Why it does it
- [ ] How it does it
- [ ] Why this approach
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Run `./gradlew build` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 99792)
Time Spent: 10m
Remaining Estimate: 0h
> GloballyAsSingletonView is writing multiple values to the SingletonView
> -----------------------------------------------------------------------
>
> Key: BEAM-4255
> URL: https://issues.apache.org/jira/browse/BEAM-4255
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.4.0
> Reporter: Batkhuyag Batsaikhan
> Assignee: Batkhuyag Batsaikhan
> Priority: Major
> Fix For: 3.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The code snippet below is writing multiple values to the sideInput. Resulting in exception: "PCollection with more than one element accessed as a singleton view."
> PCollectionView<Integer> globalView = input
> .apply(Window.<Integer>into(new GlobalWindows())
> .triggering(Repeatedly.forever(AfterPane.elementCountAtLeast(1)))
> .accumulatingFiredPanes())
> .apply(Sum.integersGlobally().asSingletonView())
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)