[GitHub] [orc] wgtmac commented on a diff in pull request #1455: ORC-1401: [C++] allow writing an intermediate footer

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #1455:
URL: https://github.com/apache/orc/pull/1455#discussion_r1163491151


##########
c++/src/Writer.cc:
##########
@@ -307,6 +307,8 @@ namespace orc {
     static const char* magicId;
     static const WriterId writerId;
     bool useTightNumericVector;
+    long stripesAtLastFlush;

Review Comment:
   ```suggestion
       size_t stripesAtLastFlush;
   ```



##########
c++/src/Writer.cc:
##########
@@ -307,6 +307,8 @@ namespace orc {
     static const char* magicId;
     static const WriterId writerId;
     bool useTightNumericVector;
+    long stripesAtLastFlush;
+    long lastFlushOffset;

Review Comment:
   ```suggestion
       int64_t lastFlushOffset;
   ```



##########
c++/src/Writer.cc:
##########
@@ -319,6 +321,8 @@ namespace orc {
 
     void addUserMetadata(const std::string& name, const std::string& value) override;
 
+    long writeIntermediateFooter() override;

Review Comment:
   ```suggestion
       int64_t writeIntermediateFooter() override;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org