You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Patrik Karlström <pa...@gmail.com> on 2022/11/29 05:16:08 UTC
NB 16, Smaller font by design?
On Windows and FlatLaf I noticed that the IDE window title font is much
smaller in nb 16 than in nb 15.
Is that by design?
I think I noticed a smaller font in popup menues on Linux too, but I have
to confirm that.
Patrik
Re: NB 16, Smaller font by design?
Posted by Patrik Karlström <pa...@gmail.com>.
Now I see that the window title font does not respect the --fontsize
argument.
The integrated menu bar still do though.
Patrik
Den tis 29 nov. 2022 06:16Patrik Karlström <pa...@gmail.com> skrev:
> On Windows and FlatLaf I noticed that the IDE window title font is much
> smaller in nb 16 than in nb 15.
>
> Is that by design?
>
> I think I noticed a smaller font in popup menues on Linux too, but I have
> to confirm that.
>
> Patrik
>
Re: NB 16, Smaller font by design?
Posted by Patrik Karlström <pa...@trixon.se>.
Den mån 5 dec. 2022 kl 19:21 skrev Neil C Smith <ne...@apache.org>:
> On Mon, 5 Dec 2022 at 14:06, Patrik Karlström <pa...@trixon.se> wrote:
> >
> > Den fre 2 dec. 2022 kl 12:50 skrev Patrik Karlström <pa...@trixon.se>:
> >
> > >
> > > TitlePane.font={font}$Label.font
> > >>
> > >> Save the file and restart NetBeans. Is that better?
> > >>
> > >> Neil
> > >>
> > >
> > > Thanks, I'll try this on Monday when I'm back on Windows.
> > >
> > >
> > Works great! Will use that until NB 17.
>
> Good to know.
>
> > Not a problem, just an observation; Hitting the "Edit custom properties
> > button" on a platform app without editors(?) results in
> > SEVERE [org.openide.util.Exceptions]
> > java.lang.NullPointerException: Cannot invoke
> > "org.netbeans.api.actions.Editable.edit()" because "editable" is null
>
> Hmmm. That's annoying. Pretty sure some basic editor support is
> brought in already by the dependencies of the options panel? I
> deliberately implemented this without adding additional dependencies
> other than those brought in transiently already.
>
> Maybe should have used Openable here? Or fall back to Openable if
> Editable is null?
>
> Any chance you could step through and find what DataObject we have
> here, and why it's not got an Editable?
>
> Ideally we might look at branding this button visibility. Ideally we
> might also look at splitting off the options panel for FlatLaf into a
> separate module with different dependencies. That was discussed in
> https://github.com/apache/netbeans/pull/4719
>
> Incidentally, I think this should support registering the additional
> properties file directly in a layer too, so might also be a way to
> deliver overrides for platform applications.
>
> Best wishes,
>
> Neil
>
Not really sure what you want me to step through but I created a new
platform project and added org-netbeans-swing-laf-flatlaf as a dependency
in order to reach it from the debugger.
With a breakpoint I get org.openide.loaders.DefaultDataObject@6dfe9bb0
[MultiFileObject@1a0c1113[LookAndFeel/FlatLaf.properties]] as the string
representation of the dob.
What else should I look for?
Patrik
Re: NB 16, Smaller font by design?
Posted by Neil C Smith <ne...@apache.org>.
On Mon, 5 Dec 2022 at 14:06, Patrik Karlström <pa...@trixon.se> wrote:
>
> Den fre 2 dec. 2022 kl 12:50 skrev Patrik Karlström <pa...@trixon.se>:
>
> >
> > TitlePane.font={font}$Label.font
> >>
> >> Save the file and restart NetBeans. Is that better?
> >>
> >> Neil
> >>
> >
> > Thanks, I'll try this on Monday when I'm back on Windows.
> >
> >
> Works great! Will use that until NB 17.
Good to know.
> Not a problem, just an observation; Hitting the "Edit custom properties
> button" on a platform app without editors(?) results in
> SEVERE [org.openide.util.Exceptions]
> java.lang.NullPointerException: Cannot invoke
> "org.netbeans.api.actions.Editable.edit()" because "editable" is null
Hmmm. That's annoying. Pretty sure some basic editor support is
brought in already by the dependencies of the options panel? I
deliberately implemented this without adding additional dependencies
other than those brought in transiently already.
Maybe should have used Openable here? Or fall back to Openable if
Editable is null?
Any chance you could step through and find what DataObject we have
here, and why it's not got an Editable?
Ideally we might look at branding this button visibility. Ideally we
might also look at splitting off the options panel for FlatLaf into a
separate module with different dependencies. That was discussed in
https://github.com/apache/netbeans/pull/4719
Incidentally, I think this should support registering the additional
properties file directly in a layer too, so might also be a way to
deliver overrides for platform applications.
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: NB 16, Smaller font by design?
Posted by Patrik Karlström <pa...@trixon.se>.
Den fre 2 dec. 2022 kl 12:50 skrev Patrik Karlström <pa...@trixon.se>:
>
> TitlePane.font={font}$Label.font
>>
>> Save the file and restart NetBeans. Is that better?
>>
>> Neil
>>
>
> Thanks, I'll try this on Monday when I'm back on Windows.
>
>
Works great! Will use that until NB 17.
Not a problem, just an observation; Hitting the "Edit custom properties
button" on a platform app without editors(?) results in
SEVERE [org.openide.util.Exceptions]
java.lang.NullPointerException: Cannot invoke
"org.netbeans.api.actions.Editable.edit()" because "editable" is null
[catch] at
org.netbeans.swing.laf.flatlaf.FlatLafOptionsPanel.lambda$customPropertiesButtonActionPerformed$0(FlatLafOptionsPanel.java:223)
at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
at
org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
at
org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033)
Re: NB 16, Smaller font by design?
Posted by Patrik Karlström <pa...@trixon.se>.
Den fre 2 dec. 2022 kl 12:41 skrev Neil C Smith <ne...@apache.org>:
> On Fri, 2 Dec 2022 at 08:16, Patrik Karlström <pa...@trixon.se> wrote:
> >
> > I filled an issue with pictures of how it looks for me.
> > https://github.com/apache/netbeans/issues/5041
> >
>
> Looking at what changed we have
> https://github.com/JFormDesigner/FlatLaf/issues/589 I guess the LAF
> customs need updating in NB17.
>
> A fun change in NB16 is Tools / Options / Appearance / FlatLaf / Edit
> custom properties
>
> Try that, and add
>
> TitlePane.font={font}$Label.font
>
> Save the file and restart NetBeans. Is that better?
>
> Neil
>
Thanks, I'll try this on Monday when I'm back on Windows.
Patrik
Re: NB 16, Smaller font by design?
Posted by Neil C Smith <ne...@apache.org>.
On Fri, 2 Dec 2022 at 08:16, Patrik Karlström <pa...@trixon.se> wrote:
>
> I filled an issue with pictures of how it looks for me.
> https://github.com/apache/netbeans/issues/5041
>
Looking at what changed we have
https://github.com/JFormDesigner/FlatLaf/issues/589 I guess the LAF
customs need updating in NB17.
A fun change in NB16 is Tools / Options / Appearance / FlatLaf / Edit
custom properties
Try that, and add
TitlePane.font={font}$Label.font
Save the file and restart NetBeans. Is that better?
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: NB 16, Smaller font by design?
Posted by Patrik Karlström <pa...@trixon.se>.
I filled an issue with pictures of how it looks for me.
https://github.com/apache/netbeans/issues/5041
Den ons 30 nov. 2022 kl 13:44 skrev Jean-Marc Borer <jm...@gmail.com>:
> Hi,
>
> On Windows I think they look the same. I use anyway a bigger font via the
> --fontsize argument.
>
> JMB
>
> On Tue, Nov 29, 2022 at 6:42 PM Patrik Karlström <pata.karlstrom@gmail.com
> >
> wrote:
>
> > On Windows and FlatLaf I noticed that the IDE window title font is much
> > smaller in nb 16 than in nb 15.
> >
> > Is that by design?
> >
> > I think I noticed a smaller font in popup menues on Linux too, but I have
> > to confirm that.
> >
> > Patrik
> >
>
Re: NB 16, Smaller font by design?
Posted by Jean-Marc Borer <jm...@gmail.com>.
Hi,
On Windows I think they look the same. I use anyway a bigger font via the
--fontsize argument.
JMB
On Tue, Nov 29, 2022 at 6:42 PM Patrik Karlström <pa...@gmail.com>
wrote:
> On Windows and FlatLaf I noticed that the IDE window title font is much
> smaller in nb 16 than in nb 15.
>
> Is that by design?
>
> I think I noticed a smaller font in popup menues on Linux too, but I have
> to confirm that.
>
> Patrik
>