You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ponymail.apache.org by GitBox <gi...@apache.org> on 2021/10/07 15:05:11 UTC
[GitHub] [incubator-ponymail-foal] sebbASF opened a new issue #113: Broken comparison: header value is terminated with \r\n, but lid is not
sebbASF opened a new issue #113:
URL: https://github.com/apache/incubator-ponymail-foal/issues/113
https://github.com/apache/incubator-ponymail-foal/blob/4bbc470aab8623512f1d932e843154ec558b8648/tools/plugins/dkim_id.py#L327
As the subject says.
The code needs to be fixed, and a test added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ponymail-foal] sebbASF commented on issue #113: Broken comparison: header value is terminated with \r\n, but lid is not
Posted by GitBox <gi...@apache.org>.
sebbASF commented on issue #113:
URL: https://github.com/apache/incubator-ponymail-foal/issues/113#issuecomment-939128634
It seems to me that the current strategy is inherently fragile: as can be seen from the above, the dkim generator is not guaranteed to agree with the main parser on the original list id.
Rather than the generator trying to re-calculate the lid, it would be a lot safer for the original lid to be passed to the generators from the archiver/importer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ponymail-foal] sebbASF commented on issue #113: Broken comparison: header value is terminated with \r\n, but lid is not
Posted by GitBox <gi...@apache.org>.
sebbASF commented on issue #113:
URL: https://github.com/apache/incubator-ponymail-foal/issues/113#issuecomment-939107483
There's another problem: the lid is not normalised before comparison: it may be of the form:
"Maven Developers List" <dev.maven.apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org