[jira] [Commented] (JCRVLT-415) jackrabbit-emptyelements validator reports error for nested folders

["Konrad Windszus (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045305#comment-17045305 ] 

Konrad Windszus commented on JCRVLT-415:
----------------------------------------

IMHO the report is correct, as this package will never modify an existing {{/test/foo}} node. This is rather an issue of the exporter that the primaryType is not included for nt:folders!. Just check by first installing my package  [^test2.zip] and afterwards install yours. You can see that test2 sets the nodetype of {{/test/foo}} to {{nt:unstructured}} with the arbitrary property {{test}}. Neither the nodetype is modified not the property {{test}} is removed once you install your package   [^test.zip] afterwards. This is really dangerous!

> jackrabbit-emptyelements validator reports error for nested folders
> -------------------------------------------------------------------
>
>                 Key: JCRVLT-415
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-415
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: vlt
>    Affects Versions: 3.4.2
>            Reporter: Csaba Varga
>            Priority: Minor
>         Attachments: test.zip, test2.zip
>
>
> When an nt:folder node is present under an orderable node, the "jackrabbit-emptyelements" validator will report an issue (breaking the build with the default settings of the package Maven plugin). I believe this shouldn't be reported as an issue because the AEM Package Manager can generate packages like this. For example, see the attached test.zip file, which was exported on an out-of-the-box AEM 6.5 instance with dummy nodes.
> To reproduce, save test.zip somewhere, then invoke the validation Maven goal in the command like like this:
> {{mvn org.apache.jackrabbit:filevault-package-maven-plugin:validate-package -Dvault.packageToValidate=test.zip}}
> test.zip contains the following very simple node hierarchy:
> {{/}}
>  {{  test (nt:unstructured)}}
>  {{    foo (nt:folder)}}
>  {{      bar (nt:folder)}}
>  {{        baz (sling:OrderedFolder)}}
> The error I'm getting is:
> {{[ERROR] ValidationViolation: "jackrabbit-emptyelements: Found empty nodes: '/test/foo' (in 'test\.content.xml') (used for ordering only) which are included in the filter with mode=merge. Rather use the according include/exclude patterns."}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)