[GitHub] [calcite] vlsi commented on a change in pull request #2438: [CALCITE-4650] TopDownRuleDriver.DeriveTrait.derive produces wrong AssertionError when registering new nodes (Vladimir Ozerov)

[GitBox <gi...@apache.org>]

vlsi commented on a change in pull request #2438:
URL: https://github.com/apache/calcite/pull/2438#discussion_r659736699



##########
File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java
##########
@@ -937,7 +937,7 @@ private void derive() {
                 subset.disableEnforcing();
               }
               RelSubset relSubset = planner.register(newRel, rel);
-              assert relSubset.set == planner.getSubsetNonNull(rel).set;
+              assert relSubset.set == VolcanoPlanner.canonize(planner.getSubsetNonNull(rel)).set;

Review comment:
       This looks really suspicious.
   Should subset merge cleanup the references? Should `getSubsetNonNull` return the canonical subset?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org