[jira] [Resolved] (LUCENE-7037) Switch all exception tests to expectThrows()

["Robert Muir (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-7037.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 6.0

> Switch all exception tests to expectThrows()
> --------------------------------------------
>
>                 Key: LUCENE-7037
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7037
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 6.0
>
>         Attachments: LUCENE-7037.patch
>
>
> Tests expecting exceptions today are done in various ways.
> The best ones look like this.
> {code}
> try {
>   something();
>   fail("message");
> } catch (Exception expected) {
>   assertSomethingAbout(expected);
> }
> {code}
> But there are many forms (involving booleans and such). All of these are a little sketchy because it is all-too easy to just forget the {{fail()}} and then the whole test is useless.
> `expectThrows` was added in LUCENE-7009 which solves a lot of these problems. Its not perfect, but overall a big improvement. We should cut over all of our tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org