You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "thomhart31 (via GitHub)" <gi...@apache.org> on 2024/07/05 17:45:50 UTC
[PR] [MINOR][DOCS] Improve clarity in `lag` docstring [spark]
thomhart31 opened a new pull request, #47236:
URL: https://github.com/apache/spark/pull/47236
### What changes were proposed in this pull request?
This PR edits grammar in `pyspark.sql.functions.lag` docstring.
### Why are the changes needed?
To improve the documentation.
### Does this PR introduce any user-facing change?
No changes in behavior are introduced.
### How was this patch tested?
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48823][DOCS] Improve clarity in `lag` docstring [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #47236:
URL: https://github.com/apache/spark/pull/47236#issuecomment-2220883963
Sorry, I reverted this by 0fdebcca1857b2aaa7d89964654b54cf2da7b21c because the new format is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48823][DOCS] Improve clarity in `lag` docstring [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #47236:
URL: https://github.com/apache/spark/pull/47236#issuecomment-2333353553
Thank you, @dongjoon-hyun, for the reminder.
I have committed a fix for the style issue. Hopefully, it can pass the GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48823][DOCS] Improve clarity in `lag` docstring [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #47236:
URL: https://github.com/apache/spark/pull/47236#issuecomment-2336974434
Merged to master. Thank you @thomhart31 @dongjoon-hyun @allisonwang-db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48823][DOCS] Improve clarity in `lag` docstring [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #47236:
URL: https://github.com/apache/spark/pull/47236#issuecomment-2220693665
Merged to master, Thank you @thomhart31 @allisonwang-db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Improve clarity in `lag` docstring [spark]
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on PR #47236:
URL: https://github.com/apache/spark/pull/47236#issuecomment-2211337301
@thomhart31 thanks! please also add this JIRA in the PR title "[[SPARK-48823]..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48823][DOCS] Improve clarity in `lag` docstring [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #47236: [SPARK-48823][DOCS] Improve clarity in `lag` docstring
URL: https://github.com/apache/spark/pull/47236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48823][DOCS] Improve clarity in `lag` docstring [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #47236:
URL: https://github.com/apache/spark/pull/47236#issuecomment-2333314362
What is the current status of this PR, @thomhart31 and @yaooqinn ? Since we found that the content itself is invalid, do you want to update or shall we close this for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Improve clarity in `lag` docstring [spark]
Posted by "thomhart31 (via GitHub)" <gi...@apache.org>.
thomhart31 commented on PR #47236:
URL: https://github.com/apache/spark/pull/47236#issuecomment-2211209845
@allisonwang-db Thanks! Jira ticket [SPARK-48823](https://issues.apache.org/jira/browse/SPARK-48823) created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48823][DOCS] Improve clarity in `lag` docstring [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #47236: [SPARK-48823][DOCS] Improve clarity in `lag` docstring
URL: https://github.com/apache/spark/pull/47236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org