You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "3424672656 (via GitHub)" <gi...@apache.org> on 2024/03/12 17:15:21 UTC

[PR] Update cache moudle jdk17 and springboot3 [dubbo-samples]

3424672656 opened a new pull request, #1055:
URL: https://github.com/apache/dubbo-samples/pull/1055

   upgrade jdk17 and springboot3.2.0 and add missing annotation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update cache moudle jdk17 and springboot3 [dubbo-samples]

Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ merged PR #1055:
URL: https://github.com/apache/dubbo-samples/pull/1055


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update cache moudle jdk17 and springboot3 [dubbo-samples]

Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on PR #1055:
URL: https://github.com/apache/dubbo-samples/pull/1055#issuecomment-1996613106

   > Sorry for my expression error, please review the latest submission
   
   not necessary to reopen a new pr, just submitting to this PR would be fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update cache moudle jdk17 and springboot3 [dubbo-samples]

Posted by "3424672656 (via GitHub)" <gi...@apache.org>.
3424672656 commented on PR #1055:
URL: https://github.com/apache/dubbo-samples/pull/1055#issuecomment-1996628583

   Is there anything that needs to be revised now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update cache moudle jdk17 and springboot3 [dubbo-samples]

Posted by "3424672656 (via GitHub)" <gi...@apache.org>.
3424672656 commented on PR #1055:
URL: https://github.com/apache/dubbo-samples/pull/1055#issuecomment-1996609942

   Sorry for my expression error, please review the latest submission


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update cache moudle jdk17 and springboot3 [dubbo-samples]

Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on PR #1055:
URL: https://github.com/apache/dubbo-samples/pull/1055#issuecomment-1996426918

   Please change replace [this dependency](https://github.com/apache/dubbo-samples/pull/1055/files#diff-337b74a6683314916ec35b3ac532137514f4c766cd7261eb2db3bfdb1bc0a529R87) with `dubbo-zookeeper-curator5-spring-boot-starter` by referencing the pom.xml file in [this sample](https://github.com/apache/dubbo-samples/blob/master/2-advanced/dubbo-samples-mock/dubbo-samples-mock-provider/pom.xml#L47)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update cache moudle jdk17 and springboot3 [dubbo-samples]

Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on PR #1055:
URL: https://github.com/apache/dubbo-samples/pull/1055#issuecomment-1996434298

   And also `<dubbo.version>3.3.0-beta.1</dubbo.version>` is needed for this starter, so please stick to `3.3.0-beta.1` instead of `3.2.11`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update cache moudle jdk17 and springboot3 [dubbo-samples]

Posted by "3424672656 (via GitHub)" <gi...@apache.org>.
3424672656 commented on PR #1055:
URL: https://github.com/apache/dubbo-samples/pull/1055#issuecomment-1992220211

   It's already running locally


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update cache moudle jdk17 and springboot3 [dubbo-samples]

Posted by "3424672656 (via GitHub)" <gi...@apache.org>.
3424672656 commented on code in PR #1055:
URL: https://github.com/apache/dubbo-samples/pull/1055#discussion_r1523078893


##########
2-advanced/dubbo-samples-cache/pom.xml:
##########
@@ -36,12 +36,12 @@
     <description>Dubbo Samples Cache</description>
 
     <properties>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
+        <maven.compiler.source>17</maven.compiler.source>
+        <maven.compiler.target>17</maven.compiler.target>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 
-        <dubbo.version>3.2.6</dubbo.version>
-        <spring-boot.version>2.7.8</spring-boot.version>
+        <dubbo.version>3.3.0-beta.1</dubbo.version>
+        <spring-boot.version>3.2.0</spring-boot.version>

Review Comment:
   change completed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update cache moudle jdk17 and springboot3 [dubbo-samples]

Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on code in PR #1055:
URL: https://github.com/apache/dubbo-samples/pull/1055#discussion_r1524246629


##########
2-advanced/dubbo-samples-cache/pom.xml:
##########
@@ -36,12 +36,12 @@
     <description>Dubbo Samples Cache</description>
 
     <properties>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
+        <maven.compiler.source>17</maven.compiler.source>
+        <maven.compiler.target>17</maven.compiler.target>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 
-        <dubbo.version>3.2.6</dubbo.version>
-        <spring-boot.version>2.7.8</spring-boot.version>
+        <dubbo.version>3.3.0-beta.1</dubbo.version>

Review Comment:
   Must use `<dubbo.version>3.3.0-beta.1</dubbo.version>` in order to showcase usage of `dubbo-zookeeper-curator5-spring-boot-starter`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update cache moudle jdk17 and springboot3 [dubbo-samples]

Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on code in PR #1055:
URL: https://github.com/apache/dubbo-samples/pull/1055#discussion_r1523019049


##########
2-advanced/dubbo-samples-cache/pom.xml:
##########
@@ -36,12 +36,12 @@
     <description>Dubbo Samples Cache</description>
 
     <properties>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
+        <maven.compiler.source>17</maven.compiler.source>
+        <maven.compiler.target>17</maven.compiler.target>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 
-        <dubbo.version>3.2.6</dubbo.version>
-        <spring-boot.version>2.7.8</spring-boot.version>
+        <dubbo.version>3.3.0-beta.1</dubbo.version>

Review Comment:
   ```suggestion
           <dubbo.version>3.2.11</dubbo.version>
   ```



##########
2-advanced/dubbo-samples-cache/pom.xml:
##########
@@ -36,12 +36,12 @@
     <description>Dubbo Samples Cache</description>
 
     <properties>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
+        <maven.compiler.source>17</maven.compiler.source>
+        <maven.compiler.target>17</maven.compiler.target>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 
-        <dubbo.version>3.2.6</dubbo.version>
-        <spring-boot.version>2.7.8</spring-boot.version>
+        <dubbo.version>3.3.0-beta.1</dubbo.version>
+        <spring-boot.version>3.2.0</spring-boot.version>

Review Comment:
   ```suggestion
           <spring-boot.version>3.2.3</spring-boot.version>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update cache moudle jdk17 and springboot3 [dubbo-samples]

Posted by "3424672656 (via GitHub)" <gi...@apache.org>.
3424672656 commented on PR #1055:
URL: https://github.com/apache/dubbo-samples/pull/1055#issuecomment-1996576684

   Please review the latest pr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Update cache moudle jdk17 and springboot3 [dubbo-samples]

Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on PR #1055:
URL: https://github.com/apache/dubbo-samples/pull/1055#issuecomment-1996601543

   > Please review the latest pr
   
   Have you already submitted it? You can cross-reference that pr in the comment here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org