[GitHub] [iceberg] arminnajafi commented on a change in pull request #4175: AWS: Use independent http client for AWS clients

[GitBox <gi...@apache.org>]

arminnajafi commented on a change in pull request #4175:
URL: https://github.com/apache/iceberg/pull/4175#discussion_r812549780



##########
File path: aws/src/integration/java/org/apache/iceberg/aws/TestAssumeRoleAwsClientFactory.java
##########
@@ -58,7 +60,7 @@ public void before() {
     roleName = UUID.randomUUID().toString();
     iam = IamClient.builder()
         .region(Region.AWS_GLOBAL)
-        .httpClient(UrlConnectionHttpClient.create())
+        .httpClientBuilder(HTTP_CLIENT_BUILDER_DEFAULT)

Review comment:
       To my understanding we are just sharing the builder in this way and we are not creating any http clients just yet. The AWS client will use this builder to create a separate http client and will manage its life cycle. 
   
   Am I missing something? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org