You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/09 20:04:16 UTC
[GitHub] [spark] nchammas edited a comment on issue #27800:
[SPARK-31041][BUILD] Show Maven errors from within make-distribution.sh
nchammas edited a comment on issue #27800: [SPARK-31041][BUILD] Show Maven errors from within make-distribution.sh
URL: https://github.com/apache/spark/pull/27800#issuecomment-596749368
Ok, curl and wget will now never show progress bars, but they will still show errors they encounter:
```sh
$ ./build/mvn
exec: curl --silent --show-error -L https://downloads.lightbend.com/zinc/0.3.15
/zinc-0.3.15.tgz
exec: curl --silent --show-error -L https://downloads.lightbend.com/scala/2.12.
10/scala-2.12.10.tgz
exec: curl --silent --show-error -L https://www.apache.org/dyn/closer.lua?action=download&filename=/maven/maven-3/3.6.3/binaries/apache-maven-3.6.3-bin.tar.gz
Using `mvn` from path: .../spark/build/apache-maven-3.6.3/bin/mvn
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
...
```
Testing wget specifically:
```diff
$ git diff
diff --git a/build/mvn b/build/mvn
index 53a77f6e81..47b0826ac0 100755
--- a/build/mvn
+++ b/build/mvn
@@ -42,9 +42,9 @@ install_app() {
# check if we already have the tarball
# check if we have curl installed
# download application
- [ ! -f "${local_tarball}" ] && [ $(command -v curl) ] && \
- echo "exec: curl ${curl_opts} ${remote_tarball}" 1>&2 && \
- curl ${curl_opts} "${remote_tarball}" > "${local_tarball}"
+ # [ ! -f "${local_tarball}" ] && [ $(command -v curl) ] && \
+ # echo "exec: curl ${curl_opts} ${remote_tarball}" 1>&2 && \
+ # curl ${curl_opts} "${remote_tarball}" > "${local_tarball}"
# if the file still doesn't exist, lets try `wget` and cross our fingers
[ ! -f "${local_tarball}" ] && [ $(command -v wget) ] && \
echo "exec: wget ${wget_opts} ${remote_tarball}" 1>&2 && \
```
```sh
$ ./build/mvn
exec: wget --no-verbose https://downloads.lightbend.com/zinc/0.3.15/zinc-0.3.15.tgz
2020-03-09 16:01:12 URL:https://downloads.lightbend.com/zinc/0.3.15/zinc-0.3.15.tgz [24682167/24682167] -> ".../spark/build/zinc-0.3.15.tgz" [1]
exec: wget --no-verbose https://downloads.lightbend.com/scala/2.12.10/scala-2.12.10.tgz
2020-03-09 16:01:18 URL:https://downloads.lightbend.com/scala/2.12.10/scala-2.12.10.tgz [20669259/20669259] -> ".../spark/build/scala-2.12.10.tgz" [1]
exec: wget --no-verbose https://www.apache.org/dyn/closer.lua?action=download&filename=/maven/maven-3/3.6.3/binaries/apache-maven-3.6.3-bin.tar.gz
2020-03-09 16:01:27 URL:http://apache.cs.utah.edu//maven/maven-3/3.6.3/binaries/apache-maven-3.6.3-bin.tar.gz [9506321/9506321] -> ".../spark/build/apache-maven-3.6.3-bin.tar.gz" [1]
Using `mvn` from path: .../spark/build/apache-maven-3.6.3/bin/mvn
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org