You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by cu...@apache.org on 2007/03/30 23:04:47 UTC

svn commit: r524271 - in /lucene/hadoop/trunk: CHANGES.txt src/java/org/apache/hadoop/dfs/DataNode.java

Author: cutting
Date: Fri Mar 30 14:04:46 2007
New Revision: 524271

URL: http://svn.apache.org/viewvc?view=rev&rev=524271
Log:
HADOOP-1170.  Improve datanode performance by removing device checks from common operations.  Contributed by Igor Bolotin.

Modified:
    lucene/hadoop/trunk/CHANGES.txt
    lucene/hadoop/trunk/src/java/org/apache/hadoop/dfs/DataNode.java

Modified: lucene/hadoop/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/CHANGES.txt?view=diff&rev=524271&r1=524270&r2=524271
==============================================================================
--- lucene/hadoop/trunk/CHANGES.txt (original)
+++ lucene/hadoop/trunk/CHANGES.txt Fri Mar 30 14:04:46 2007
@@ -79,6 +79,9 @@
 24. HADOOP-672.  Improve help for fs shell commands.
     (Dhruba Borthakur via cutting)
 
+25. HADOOP-1170.  Improve datanode performance by removing device
+    checks from common operations.  (Igor Bolotin via cutting)
+
 
 Release 0.12.3 (not yet released)
 

Modified: lucene/hadoop/trunk/src/java/org/apache/hadoop/dfs/DataNode.java
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/java/org/apache/hadoop/dfs/DataNode.java?view=diff&rev=524271&r1=524270&r2=524271
==============================================================================
--- lucene/hadoop/trunk/src/java/org/apache/hadoop/dfs/DataNode.java (original)
+++ lucene/hadoop/trunk/src/java/org/apache/hadoop/dfs/DataNode.java Fri Mar 30 14:04:46 2007
@@ -419,7 +419,6 @@
             lastHeartbeat = now;
 
             if( cmd != null ) {
-              data.checkDataDir();
               switch( cmd.action ) {
               case DNA_TRANSFER:
                 //
@@ -454,9 +453,6 @@
             
           // send block report
           if (now - lastBlockReport > blockReportInterval) {
-            // before send block report, check if data directory is healthy
-            data.checkDataDir();
-                
             //
             // Send latest blockinfo report if timer has expired.
             // Get back a list of local block(s) that are obsolete
@@ -558,15 +554,10 @@
                 while (shouldRun) {
                     Socket s = ss.accept();
                     //s.setSoTimeout(READ_TIMEOUT);
-                    data.checkDataDir();
                     xceiverCount.incr();
                     new Daemon(new DataXceiver(s)).start();
                 }
                 ss.close();
-            } catch (DiskErrorException de ) {
-                String errMsgr = de.getMessage();
-                LOG.warn("Exiting DataXceiveServer due to "+ errMsgr );
-                handleDiskError(errMsgr);
             } catch (IOException ie) {
                 LOG.info("Exiting DataXceiveServer due to " + ie.toString());
             }