[jira] Commented: (IVY-531) ivyconf: to accept complex path

["Xavier Hanin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IVY-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581655#action_12581655 ] 

Xavier Hanin commented on IVY-531:
----------------------------------

I've quickly reviewed the patch, very good quality, good job. I've only one concern about this implementation: supporting 'path' attribute only when used from Ant is a strong limitation IMO. The classpath mechanism in Ivy settings is mainly used to be able to use plugins from any kind of Ivy use consistently (command line, Ant, IvyDE, ...). When used from Ant, you can use Ant path mechanism when loading Ivy itself, so that plugins are available to the classloader loading Ivy itself. So supporting refid is a nice addition for a better Ant integration, but I really believe this issue would better be supported if the path attribute was implemented in Ivy core, without relying on Ant. One could say that we could later do that, and provide a limited feature, but the problem is that we'll later need to support all Ant path syntax if we do it that way.

So I see two options:
- rename 'path' to 'antpath', to keep the 'path' attribute for a later implementation of what was really asked in this issue
- implement 'path' in IvyClassLoaderManagerImpl

WDYT?


> ivyconf: <classpath/> to accept complex path
> --------------------------------------------
>
>                 Key: IVY-531
>                 URL: https://issues.apache.org/jira/browse/IVY-531
>             Project: Ivy
>          Issue Type: Improvement
>          Components: Ant
>         Environment: Any
>            Reporter: Eric Crahen
>            Priority: Minor
>         Attachments: ivy-ant-classpath.patch
>
>
> Eric:
> The ivyconf.xml classpath tag accepts file or url elements which seem capable of pointing to only a single classpath element, either a path or a jar. Can a full classpath be expressed?
> For instance, I would like to set an ant property called my.classpath and have it contain something like "a.jar:b.jar:c.jar". I'd like to use that property in my ivyconf.xml in a classpath element to set the classpath for resolver with complex dependencies
> Xavier:
> Sounds like a good idea, but this is not implemented yet. Open a jira issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.