[jira] [Resolved] (WICKET-5823) DefaultAuthenticationStrategy should be modified to reduce copy/paste while extending it's functionality

["Martin Grigorov (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-5823.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 7.0.0-M6
                   6.20.0
         Assignee: Martin Grigorov

I've applied the patch for Wicket 6.x both to 6.x and 7.x.
The patch for Wicket 7.x looks too much to me. I don't see the reason why there should be both #save(String username, String password) and #save(String[]) in the API. The new one (with String[]) doesn't look good to me.
Please start a discussion at dev@ explaining your reasons if you believe it should be added.
Thanks!

> DefaultAuthenticationStrategy should be modified to reduce copy/paste while extending it's functionality
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-5823
>                 URL: https://issues.apache.org/jira/browse/WICKET-5823
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 6.18.0, 7.0.0-M4
>            Reporter: Maxim Solodovnik
>            Assignee: Martin Grigorov
>              Labels: patch
>             Fix For: 6.20.0, 7.0.0-M6
>
>         Attachments: wicket6.patch, wicket7.patch
>
>
> Currently all fields are private and methods should be copy/pasted to extend DefaultAuthenticationStrategy.
> I propose to extend IAuthenticationStrategy in wicket7 to enable store as much fields in cookie as necessary and modify wicket6 without code-break.
> Please see the patches attached



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)