You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2009/08/13 18:47:15 UTC

[jira] Created: (SOLR-1362) WordDelimiterFilter position increment bug

WordDelimiterFilter position increment bug
------------------------------------------

                 Key: SOLR-1362
                 URL: https://issues.apache.org/jira/browse/SOLR-1362
             Project: Solr
          Issue Type: Bug
          Components: Analysis
            Reporter: Robert Muir
            Priority: Minor
         Attachments: SOLR-1362.patch

WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.

If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated SOLR-1362:
-------------------------------

    Attachment: SOLR-1362.patch

I had implemented the "remove normal posIncr" this morning - just got around to adding a test though.  Seems to work - can you see if this matches your expectations?

I think about it like this:  position increments serve two purposes... to signify the normal case of tokens being adjacent to each other, and to separate groups of tokens.  In the former case, it makes sense to completely consume the delimiter and keep the resulting tokens next to eachother.  In the later case, we want to preserve the logical separation.

> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch, SOLR-1362.patch, SOLR-1362.patch, SOLR-1362_tests.txt
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742895#action_12742895 ] 

Yonik Seeley commented on SOLR-1362:
------------------------------------

Hmmm, at first blush, it seems like we're just trying to preserve the positioning of the original tokens... so 
"foo !@# bar" will index to "foo (blank) bar"

Is that the issue?

> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747754#action_12747754 ] 

Robert Muir commented on SOLR-1362:
-----------------------------------

actually one last thing Yonik, at the beginning of the processing loop (now i am just nitpicking)

{code}
     //skip protected tokens
      if (protWords != null && protWords.contains(termBuffer, 0, len)) {
        return t;
      }

      int posInc = t.getPositionIncrement();
      origPosIncrement += posInc;
      ...
{code}

I should have written testcase, but don't you think if you have a LUCENE / SOLR where "/" has a huge gap, and SOLR is in 'protWords' that this might result in strange behavior?


> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch, SOLR-1362.patch, SOLR-1362.patch, SOLR-1362_tests.txt
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747476#action_12747476 ] 

Yonik Seeley edited comment on SOLR-1362 at 8/25/09 9:21 AM:
-------------------------------------------------------------

Thanks Robert... looking into it.

      was (Author: yseeley@gmail.com):
    Thanks Robert... this is strange - I don't even see how the gap can be maintained sometimes with the current code.  Something strange is going on here.
  
> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch, SOLR-1362_tests.txt
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley resolved SOLR-1362.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4

Committed, thanks Robert!

> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-1362.patch, SOLR-1362.patch, SOLR-1362.patch, SOLR-1362.patch, SOLR-1362_tests.txt
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747655#action_12747655 ] 

Robert Muir commented on SOLR-1362:
-----------------------------------

Yonik, thanks! I will work on the skipped token subtraction tonight, but your patch has restored order :)

> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch, SOLR-1362.patch, SOLR-1362_tests.txt
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745186#action_12745186 ] 

Robert Muir commented on SOLR-1362:
-----------------------------------

Yonik, in this case I think existing gaps would be preserved with the =
the question is what should the behavior be for tokens that are all delimiters, currently these are discarded and posInc is incremented for future tokens.

with the current behavior, if you have "LUCENE / SOLR" (all with posInc=1), this becomes LUCENE (posInc=1), SOLR (posInc=2)
if you change it to =, if you have "LUCENE / SOLR" (pretend SOLR has posInc=3), the posInc=3 would still be preserved, it would just not become 4.

its clear to me looking at history its been like this for a long time, so maybe I am incorrect to categorize it as a bug?
But I found this behavior to be a little unexpected, especially for phrase queries, and given the way the code reads, I wasn't certain if it was intentional.


> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745516#action_12745516 ] 

Yonik Seeley commented on SOLR-1362:
------------------------------------

bq. Yonik, in this case I think existing gaps would be preserved with the =

What if the big position increment was on a token that was all delimiters?

I agree that it makes more sense for "LUCENE / SOLR" to be translated to LUCENE SOLR without a gap though (provided that there are no gaps to start with).

Should the rule be, subtract 1 from the cumulative position increment if the increment of the current token being added is >=1 ?


> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747476#action_12747476 ] 

Yonik Seeley commented on SOLR-1362:
------------------------------------

Thanks Robert... this is strange - I don't even see how the gap can be maintained sometimes with the current code.  Something strange is going on here.

> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch, SOLR-1362_tests.txt
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742995#action_12742995 ] 

Robert Muir commented on SOLR-1362:
-----------------------------------

fyi this line of code was changed from = to += in SOLR-14, which in general appears to be an unrelated issue 

there is one comment about wdf doing the "wrong thing" with positions, but i cannot tell if it was intentional or not.


> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated SOLR-1362:
------------------------------

    Attachment: SOLR-1362.patch

> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747752#action_12747752 ] 

Robert Muir commented on SOLR-1362:
-----------------------------------

bq. I had implemented the "remove normal posIncr" this morning - just got around to adding a test though. Seems to work - can you see if this matches your expectations? 

I tested some with this patch some and I like this behavior.

bq. I think about it like this: position increments serve two purposes... to signify the normal case of tokens being adjacent to each other, and to separate groups of tokens. In the former case, it makes sense to completely consume the delimiter and keep the resulting tokens next to eachother. In the later case, we want to preserve the logical separation.

Yes, I think this fixes the behavior for both purposes.

> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch, SOLR-1362.patch, SOLR-1362.patch, SOLR-1362_tests.txt
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated SOLR-1362:
-------------------------------

    Attachment: SOLR-1362.patch

OK, here's a patch that increases the consistency.

>From here I think we should subtract 1 for every skipped token that had a position increment of 1.  It's not possible to fix these bugs and keep back compatibility, so I don't think we need a config option for this.

> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch, SOLR-1362.patch, SOLR-1362_tests.txt
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated SOLR-1362:
------------------------------

    Attachment: SOLR-1362.patch

patch that moves the protWords check below the posInc calculation, and sets it.

> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch, SOLR-1362.patch, SOLR-1362.patch, SOLR-1362.patch, SOLR-1362_tests.txt
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated SOLR-1362:
------------------------------

    Attachment: SOLR-1362_tests.txt

I started working on a patch, but found the existing behavior to be more strange than I originally thought.

there are some bugs in the existing behavior as well, completely separate but along the same lines of this issue.

So here are some tests, let me know what you think...

> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch, SOLR-1362_tests.txt
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745541#action_12745541 ] 

Yonik Seeley commented on SOLR-1362:
------------------------------------

bq. I assume it should be as an option for back compat?

I guess so, yes... there may be configurations where it makes sense.


> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745520#action_12745520 ] 

Robert Muir commented on SOLR-1362:
-----------------------------------

ah, i see your point... 

sounds right to me. i can reformulate the patch/tests in this direction.

I assume it should be as an option for back compat?

> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742983#action_12742983 ] 

Robert Muir commented on SOLR-1362:
-----------------------------------

yonik, maybe: i am unable to tell from docs/tests if it is a bug or not. from the code (especially the variable name) it looks suspicious.

but this is what i mean, i guess it could be desirable for some folks? So I could make it another option...?


> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1362) WordDelimiterFilter position increment bug

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745113#action_12745113 ] 

Yonik Seeley commented on SOLR-1362:
------------------------------------

I could see perhaps wanting WDF to not create new gaps, but it should normally preserve existing gaps, right?  In which case, a patch would be more complex than conditionally changing "+=" to "="


> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.