You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/05/18 19:11:53 UTC
[GitHub] [storm] kishorvpatil opened a new pull request #3271: MINOR PATCH: Avoid fragmented resources on supervisor creation in nimbus
kishorvpatil opened a new pull request #3271:
URL: https://github.com/apache/storm/pull/3271
## What is the purpose of the change
If the underlying scheduler is not _ResourceAwareScheduler_ and scheduler has no resources to register, then it does not have to calculate or report any resources.
*(Explain why we should have this change)*
## How was the change tested
local unit tests.
*(Explain what tests did you do to verify the code change)*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm commented on a change in pull request #3271: MINOR PATCH: Avoid fragmented resources on supervisor creation in nimbus
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on a change in pull request #3271:
URL: https://github.com/apache/storm/pull/3271#discussion_r426884017
##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -2920,7 +2920,7 @@ private SupervisorSummary makeSupervisorSummary(String supervisorId, SupervisorI
(int) info.get_uptime_secs(), numPorts, numUsedPorts, supervisorId);
ret.set_total_resources(info.get_resources_map());
SupervisorResources resources = nodeIdToResources.get().get(supervisorId);
- if (resources != null) {
+ if (resources != null && underlyingScheduler instanceof ResourceAwareScheduler) {
Review comment:
What's the issue we want to solve here?
If it is just about skipping the code related to resources when the scheduler is not resourceAware, then we have other places like `getTopologyPageInfo` we need to take care of
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] kishorvpatil commented on a change in pull request #3271: MINOR PATCH: Avoid fragmented resources on supervisor creation in nimbus
Posted by GitBox <gi...@apache.org>.
kishorvpatil commented on a change in pull request #3271:
URL: https://github.com/apache/storm/pull/3271#discussion_r429318153
##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -2920,7 +2920,7 @@ private SupervisorSummary makeSupervisorSummary(String supervisorId, SupervisorI
(int) info.get_uptime_secs(), numPorts, numUsedPorts, supervisorId);
ret.set_total_resources(info.get_resources_map());
SupervisorResources resources = nodeIdToResources.get().get(supervisorId);
- if (resources != null) {
+ if (resources != null && underlyingScheduler instanceof ResourceAwareScheduler) {
Review comment:
I have updated instances where code should avoid following resource calculation if not using `ResourceAwareScheduler`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm merged pull request #3271: MINOR PATCH: Avoid fragmented resources on supervisor creation in nimbus
Posted by GitBox <gi...@apache.org>.
Ethanlm merged pull request #3271:
URL: https://github.com/apache/storm/pull/3271
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm commented on pull request #3271: MINOR PATCH: Avoid fragmented resources on supervisor creation in nimbus
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on pull request #3271:
URL: https://github.com/apache/storm/pull/3271#issuecomment-634717960
I believe we should prefix MINOR to the commit message as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org