[GitHub] [pinot] gortiz commented on a diff in pull request #10653: Remove actually unsupported config that selectively enable nullable columns

["gortiz (via GitHub)" <gi...@apache.org>]

gortiz commented on code in PR #10653:
URL: https://github.com/apache/pinot/pull/10653#discussion_r1177411649


##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/AbstractIndexType.java:
##########
@@ -51,7 +51,11 @@ public Map<String, C> getConfig(TableConfig tableConfig, Schema schema) {
     if (_deserializer == null) {
       _deserializer = createDeserializer();
     }
-    return _deserializer.deserialize(tableConfig, schema);
+    try {
+      return _deserializer.deserialize(tableConfig, schema);

Review Comment:
   With which exception? `ConfigDeclaredTwiceException`? Here we are dealing with that exception. But it wraps it in order to also inform about which index type is the one that is failing. The code that throws the original exception doesn't have the context to know which index type is the one that is repeated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org